-
Notifications
You must be signed in to change notification settings - Fork 150
feat(recommended labels) #4327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(recommended labels) #4327
Conversation
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) 2022-2024 Tigera, Inc. All rights reserved. | |||
| // Copyright (c) 2022-2025 Tigera, Inc. All rights reserved. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol on Dec 29th...
2e6cd03 to
628c1c9
Compare
628c1c9 to
1cbb0a6
Compare
| "app.kubernetes.io/instance": "tigera-secure", | ||
| "app.kubernetes.io/managed-by": "tigera-operator", | ||
| "app.kubernetes.io/name": "tigera-external-prometheus", | ||
| "app.kubernetes.io/part-of": "TigeraSecureEnterprise", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoud this just be Calico always? I think that makes more sense.
| Expect(serviceMonitor.Spec.Endpoints).To(HaveLen(1)) | ||
| // Verify that the default settings are propagated. | ||
| Expect(serviceMonitor.Labels).To(Equal(map[string]string{render.AppLabelName: monitor.TigeraExternalPrometheus})) | ||
| Expect(serviceMonitor.Labels).To(Equal(map[string]string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about app.kubernetes.io/version?
feat(recommended labels): Set recommended labels as per
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
For example:
The version label was deliberately skipped as discussed in our operator grooming meetings.