-
Notifications
You must be signed in to change notification settings - Fork 889
Update README.md #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update README.md #37
Conversation
WalkthroughThe README.md file was thoroughly rewritten to provide a comprehensive overview of the "Face it" project. Updates include a detailed project description, technical and hardware requirements, installation and usage instructions, annotated screenshots, a workflow diagram, demo links, and explicit team contributions. No code or exported entities were changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (7)
README.md (7)
27-30
: Consolidate duplicate / mixed-capitalisation bullet itemsThe software list repeats “MediaPipe” and mixes several libraries in a single bullet (
openCV,pyautogui,mediapipe
). This hurts readability and makes package requirements unclear.
Consider splitting each dependency into its own, consistently-capitalised bullet:- - Python - - MediaPipe - - openCV,pyautogui,mediapipe - - Visual Studio Code , Webcam + - Python (3.9+) + - MediaPipe + - OpenCV + - PyAutoGUI + - Visual Studio Code + - Webcam
37-44
: Fix heading hierarchy and use fenced code blocks for commands
# Installation
and# Run
jump two heading levels down from### Implementation
, triggering MD001.
They should be####
(or keep everything at###
) and the shell commands should be fenced for copy-paste safety.-# Installation -pip install opencv-python mediapipe pyautogui - -# Run -python NoseControlledMouse.py +#### Installation +```bash +pip install opencv-python mediapipe pyautogui +``` + +#### Run +```bash +python NoseControlledMouse.py +```
49-72
: Screenshots section is hard to scan – switch to numbered sub-sectionsThe long paragraph-style explanations after each
<img>
tag are dense. Using sub-headings or ordered lists will make it easier to skim and link to specific stages (initialisation, frame loop, nose control, etc.).
No diff provided because this is structural.
124-126
: Normalise the hardware subsection
For Hardware:
followed by plain text “webcam input only” renders oddly. Treat it like the software list:-For Hardware: - -webcam input only +#### Hardware Requirements +* Webcam (built-in or external, 720 p or higher)
140-147
: Convert bare URLs to Markdown links (MD034)Bare links break flow and are flagged by markdownlint. Example fix:
-https://drive.google.com/file/d/1M6LK2pmpBatKaMyYFcAg0bfmw5uFyy8n/view?usp=drivesdk +[Demo Video](https://drive.google.com/file/d/1M6LK2pmpBatKaMyYFcAg0bfmw5uFyy8n/view?usp=drivesdk) - -deployment link -https://github.com/Josh123-Joseph/Face-it +[Deployment Repository](https://github.com/Josh123-Joseph/Face-it)Repeat for any other bare URLs.
150-156
: Re-format team contributions for consistent bulletsContinuation lines are indented with spaces, so GitHub renders them as a code block. Use nested bullets instead:
-Joshua Joseph- Lead developer, gesture logic and blink screenshot implementation - Integrated face mesh visualization - UI debugging and responsiveness - -Jeff Jacob Mathew- Testing and parameter tuning (mouth click sensitivity, blink delay) - Screenshot display and subprocess window handling - Documentation and demo preparation +* **Joshua Joseph** + * Lead developer – gesture logic & blink-screenshot + * Integrated Face Mesh visualisation + * UI debugging & responsiveness +* **Jeff Jacob Mathew** + * Testing / parameter tuning (mouth click, blink delay) + * Screenshot display & subprocess handling + * Documentation & demo preparation
141-144
: Replace italic sentence with a heading or bullet (MD036)
*Explain what the video demonstrates*
is styled as emphasis instead of a heading, violating MD036. Convert to a proper heading or remove if redundant.-*Explain what the video demonstrates* +#### What the demo shows +Briefly describe the gestures demonstrated and expected outcome.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
45-45: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3
(MD001, heading-increment)
140-140: Bare URL used
(MD034, no-bare-urls)
143-143: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
146-146: Bare URL used
(MD034, no-bare-urls)
Summary by CodeRabbit