nrf528xx: handle BLE_GAP_EVT_PHY_UPDATE_REQUEST #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and explicitly ignore some other events
|
Worked for me, thank you very much for the improvement/fix @ysoldak now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and explicitly ignore some other events.
While working on #86, I've noticed some events are logged as "unknown" while we could just explicitly ignore them.
Also, I was not able to connect to my XIAO-BLE board from iOS via
nRF ConnectorLightBlueapps.Apparently, the problem was with unhandled
BLE_GAP_EVT_PHY_UPDATE_REQUESTevent.This is now implemented and connection happens successfully.