Skip to content

Mpu sensor rewrite 2 #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Mpu sensor rewrite 2 #577

wants to merge 1 commit into from

Conversation

soypat
Copy link
Contributor

@soypat soypat commented May 27, 2023

Resolves #544 and updates the mpu6050 to take advantage of previously unavailable features.

Replaces old PR #556

@soypat soypat changed the base branch from release to dev May 27, 2023 18:00
@soypat soypat requested review from deadprogram and aykevl May 27, 2023 18:01
@soypat soypat mentioned this pull request May 27, 2023
Closed
@aykevl
Copy link
Member

aykevl commented Sep 24, 2025

Is this something you still want to merge?
The changes look good on first glance, but there's a merge conflict and I think it would be a good idea to avoid heap allocations by using Device.data in more places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadprogram deadprogram Awaiting requested review from deadprogram

@aykevl aykevl Awaiting requested review from aykevl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MPU6050 ReadRotation not working
2 participants
@soypat @aykevl