feat: add w5500 driver #788
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysoldak
reviewed
Sep 22, 2025
w5500/w5500.go
Outdated
| // | ||
| // The SPI bus must be fully configured. | ||
| type Config struct { | ||
| SPI drivers.SPI |
There was a problem hiding this comment.
I believe we usually pass things like drivers.SPI and pins into New() method, instead of having them in Config struct.
ysoldak
reviewed
Sep 22, 2025
w5500/w5500.go
Outdated
| sockets []*socket | ||
| laddr netip.Addr | ||
|
|
||
| cmdBuf []byte |
There was a problem hiding this comment.
Suggested change
| cmdBuf []byte | |
| cmdBuf [3]byte |
and then make() can be dropped in New()
ysoldak
reviewed
Sep 22, 2025
| type Resolver func(host string) (netip.Addr, error) | ||
|
|
||
| // PinOutput is a function that sets a pin high or low. | ||
| type PinOutput func(level bool) |
There was a problem hiding this comment.
You may want to wait for #753 be merged and use PinOutput defined in drivers package then.
There was a problem hiding this comment.
Happy to wait if that is what you feel is best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a driver for the w5500 ethernet chip:
https://docs.wiznet.io/img/products/w5500/W5500_ds_v110e.pdf
While it uses interrupts, it does not use the interrupt pin as there is currently no way to implement a timed wait (something akin to a Futex). For this reason it is not as fast as it could be.
It also does not attempt to tackle DNS, just copping out and allowing the user to set a resolver when they configure the device.
I tried to abide by your Driver guide, let me know if anything is amiss.