Adding custom database name for testing.postgres #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to see this merged (I'm not affiliated with the project), can I help somehow? |
RazerM
reviewed
Oct 18, 2017
| setup( | ||
| name='testing.postgresql', | ||
| version='1.3.0', | ||
| version='1.3.1', |
There was a problem hiding this comment.
This would be a minor release, not a patch release, but the version bump should be left out of the PR anyway.
| postgres_args='-h 127.0.0.1 -F -c logging_collector=off', | ||
| pid=None, | ||
| port=None, | ||
| database='test', |
There was a problem hiding this comment.
It might be clearer to call this parameter db_name like #18
| conn.autocommit = True | ||
| with closing(conn.cursor()) as cursor: | ||
| cursor.execute("SELECT COUNT(*) FROM pg_database WHERE datname='test'") | ||
| cursor.execute("SELECT COUNT(*) FROM pg_database WHERE datname='%s'" % self.settings['database']) |
There was a problem hiding this comment.
The database name should be passed as a parameter to execute, instead of string interpolation.
craiggoddenpayne
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just implementing a simple feature that I need and giving it back to you :)