Skip to content

Conversation

th4s
Copy link
Member

@th4s th4s commented Jul 30, 2025

This PR removes the deprecated notarize and notarize_with_provider methods from the prover and verifier.

@th4s th4s requested a review from sinui0 July 30, 2025 08:04
@th4s th4s force-pushed the feat/remove-notarize-methods branch from 7d253f4 to 65dcbb4 Compare July 31, 2025 10:57
@th4s th4s changed the base branch from dev to chore/remove-notary July 31, 2025 10:57
Copy link
Member

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 loc

Base automatically changed from chore/remove-notary to dev August 4, 2025 08:41
@th4s th4s force-pushed the feat/remove-notarize-methods branch from fe8b39d to b3bdee7 Compare August 4, 2025 10:33
@th4s
Copy link
Member Author

th4s commented Aug 4, 2025

@sinui0 hmm what do we do with the wasm binding function here, just remove it, too?
https://github.com/tlsnotary/tlsn/blob/main/crates/wasm/src/prover/mod.rs#L108-L144

@sinui0
Copy link
Member

sinui0 commented Aug 6, 2025

yeah we can remove it

@sinui0 sinui0 merged commit 6578386 into dev Aug 6, 2025
10 checks passed
@sinui0 sinui0 deleted the feat/remove-notarize-methods branch August 6, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants