chore: Update dependencies and fix clippy warnings #327

bryantbiggs · 2025-04-13T14:46:28Z

Update dependencies
Correct clippy lint warnings

CI tests were executed on fork first to ensure tests pass https://github.com/bryantbiggs/tokio-uring/actions/runs/14344438841?pr=1

Closes #324
Closes #313
Closes #272

Resolves #316

bryantbiggs · 2025-04-13T14:46:54Z

cc @Noah-Kennedy if you have a few cycles to review

paolobarbolini · 2025-04-25T16:24:07Z

Drive-by review: I don't think bumping patch versions of dependencies makes sense unless the older versions have a serious security vulnerability, are completely broken or break -Zminimal-versions builds

bryantbiggs · 2025-04-25T21:52:05Z

@paolobarbolini what are the downsides of bumping the patch versions?

paolobarbolini · 2025-04-25T21:55:55Z

@paolobarbolini what are the downsides of bumping the patch versions?

The inflexibility of not being able to update things at my own pace, which for me personally I try to update things frequently, but if I have to revert to a previous version I don't want to have to downgrade or fork a second dependency just because the minimum allowed version was bumped too high.

reneleonhardt · 2025-06-30T13:15:53Z

@bryantbiggs Great contribution! Were you able to revert the unnecessary patch versions?

I updated everything to latest (nix 0.30) while only specifying minor versions (removing the patch digit).
criterion 0.6 would require MSRV 1.80.0.

diff --git a/Cargo.toml b/Cargo.toml
index 62fbef5..92376cf 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -17,22 +17,22 @@ keywords = ["async", "fs", "io-uring"]
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-tokio = { version = "1.44", features = ["net", "rt", "sync"] }
-slab = "0.4.9"
-libc = "0.2.171"
-io-uring = "0.7.4"
-socket2 = { version = "0.5.9", features = ["all"] }
-bytes = { version = "1.10.1", optional = true }
-futures-util = { version = "0.3.31", default-features = false, features = ["std"] }
+tokio = { version = "1.2", features = ["net", "rt", "sync"] }
+slab = "0.4.2"
+libc = "0.2.80"
+io-uring = "0.7"
+socket2 = { version = "0.5", features = ["all"] }
+bytes = { version = "1.0", optional = true }
+futures-util = { version = "0.3.26", default-features = false, features = ["std"] }
 
 [dev-dependencies]
-tempfile = "3.19.1"
-tokio-test = "0.4.4"
+tempfile = "3.2.0"
+tokio-test = "0.4.2"
 iai = "0.1.1"
-criterion = "0.5.1"
+criterion = "0.5"
 # we use joinset in our tests
-tokio = "1.44.2"
-nix = { version = "0.29.0", features = ["resource"] }
+tokio = "1.21.2"
+nix = { version = "0.30", features = ["resource"] }
 
 [package.metadata.docs.rs]
 all-features = true

For reference to master:

diff --git a/Cargo.toml b/Cargo.toml
index 85ce27d..92376cf 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -20,8 +20,8 @@ keywords = ["async", "fs", "io-uring"]
 tokio = { version = "1.2", features = ["net", "rt", "sync"] }
 slab = "0.4.2"
 libc = "0.2.80"
-io-uring = "0.6.0"
-socket2 = { version = "0.4.4", features = ["all"] }
+io-uring = "0.7"
+socket2 = { version = "0.5", features = ["all"] }
 bytes = { version = "1.0", optional = true }
 futures-util = { version = "0.3.26", default-features = false, features = ["std"] }
 
@@ -29,10 +29,10 @@ futures-util = { version = "0.3.26", default-features = false, features = ["std"
 tempfile = "3.2.0"
 tokio-test = "0.4.2"
 iai = "0.1.1"
-criterion = "0.4.0"
+criterion = "0.5"
 # we use joinset in our tests
 tokio = "1.21.2"
-nix = "0.26.1"
+nix = { version = "0.30", features = ["resource"] }
 
 [package.metadata.docs.rs]
 all-features = true

bryantbiggs · 2025-06-30T14:59:41Z

@paolobarbolini / @reneleonhardt done!

@Noah-Kennedy any thoughts on the changes?

tomaszduda23 · 2025-08-24T09:23:13Z

any chance to get it merged ?

tomaszduda23 · 2025-08-24T10:09:09Z

@bryantbiggs sorry to bother you. I try to compile aa-proxy-rs on alpine. I pulled your PR and still get there error:

   Compiling tokio-uring v0.5.0 (/home/pmos/build/src/tokio-uring-75bc7360a1f10a81d53e7ec08a5eff7d7ef3ded6)
   Compiling aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
error[E0412]: cannot find type `statx` in crate `libc`
   --> /home/pmos/build/src/tokio-uring-75bc7360a1f10a81d53e7ec08a5eff7d7ef3ded6/src/io/statx.rs:21:22
    |
21  |       statx: Box<libc::statx>,
    |                        ^^^^^
    |
   ::: /home/pmos/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libc-0.2.172/src/unix/linux_like/linux/musl/b64/aarch64/mod.rs:10:1

What I'm missing ?

WARNING: crossdirect: 'cargo tree -i libc' command not supported, running in QEMU (slow!)
    Updating crates.io index
     Locking 2 packages to latest compatible versions
    Updating io-uring v0.6.4 -> v0.7.10
      Adding tokio-uring v0.5.0 (/home/pmos/build/src/tokio-uring-75bc7360a1f10a81d53e7ec08a5eff7d7ef3ded6)
libc v0.2.172
├── cpufeatures v0.2.17
│   └── sha2 v0.10.9
│       [build-dependencies]
│       └── pest_meta v2.8.1
│           └── pest_generator v2.8.1
│               └── pest_derive v2.8.1 (proc-macro)
│                   └── json5 v0.4.1
│                       └── config v0.14.1
│                           └── aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
├── getrandom v0.2.16
│   └── const-random-macro v0.1.16 (proc-macro)
│       └── const-random v0.1.18
│           └── dlv-list v0.5.2
│               └── ordered-multimap v0.7.3
│                   └── rust-ini v0.20.0
│                       └── config v0.14.1 (*)
└── getrandom v0.3.3
    └── tempfile v3.20.0
        ├── protobuf-codegen v3.7.2
        │   [build-dependencies]
        │   └── aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
        └── protobuf-parse v3.7.2
            └── protobuf-codegen v3.7.2 (*)

libc v0.2.172
├── bluer v0.17.3
│   └── aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
├── dbus v0.9.7
│   ├── aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
│   ├── bluer v0.17.3 (*)
│   ├── dbus-crossroads v0.5.2
│   │   └── bluer v0.17.3 (*)
│   └── dbus-tokio v0.7.6
│       └── bluer v0.17.3 (*)
├── dbus-tokio v0.7.6 (*)
├── getrandom v0.3.3
│   └── uuid v1.17.0
│       └── bluer v0.17.3 (*)
├── io-uring v0.7.10
│   └── tokio-uring v0.5.0 (/home/pmos/build/src/tokio-uring-75bc7360a1f10a81d53e7ec08a5eff7d7ef3ded6)
│       └── aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
├── mio v1.0.4
│   └── tokio v1.45.1
│       ├── aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
│       ├── axum v0.6.20
│       │   └── aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
│       ├── bluer v0.17.3 (*)
│       ├── dbus-tokio v0.7.6 (*)
│       ├── h2 v0.3.26
│       │   └── hyper v0.14.32
│       │       ├── aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
│       │       └── axum v0.6.20 (*)
│       ├── hyper v0.14.32 (*)
│       ├── tokio-fd v0.3.0
│       │   └── aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
│       ├── tokio-stream v0.1.17
│       │   └── bluer v0.17.3 (*)
│       ├── tokio-uring v0.5.0 (/home/pmos/build/src/tokio-uring-75bc7360a1f10a81d53e7ec08a5eff7d7ef3ded6) (*)
│       ├── tokio-util v0.7.15
│       │   └── h2 v0.3.26 (*)
│       └── tower v0.4.13
│           └── axum v0.6.20 (*)
├── netif v0.1.6
│   └── aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
├── netlink-sys v0.8.7
│   └── aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
├── nix v0.29.0
│   ├── bluer v0.17.3 (*)
│   └── mac_address v1.1.8
│       └── aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
├── openssl v0.10.73
│   └── aa-proxy-rs v0.8.0 (/home/pmos/build/src/aa-proxy-rs-0.8.0)
├── openssl-sys v0.9.109
│   └── openssl v0.10.73 (*)
├── parking_lot_core v0.9.11
│   └── parking_lot v0.12.4
│       └── tokio v1.45.1 (*)
├── signal-hook-registry v1.4.5
│   └── tokio v1.45.1 (*)
├── socket2 v0.5.10
│   ├── hyper v0.14.32 (*)
│   ├── tokio v1.45.1 (*)
│   └── tokio-uring v0.5.0 (/home/pmos/build/src/tokio-uring-75bc7360a1f10a81d53e7ec08a5eff7d7ef3ded6) (*)
├── tokio v1.45.1 (*)
├── tokio-fd v0.3.0 (*)
└── tokio-uring v0.5.0 (/home/pmos/build/src/tokio-uring-75bc7360a1f10a81d53e7ec08a5eff7d7ef3ded6) (*)
================

Due to rust-lang/rust#124210, when an owned fd has already been closed before it's dropped means that something else touched the fd in ways its not allowed to. Therefore, these tests fail due to this new behavior enforcement Signed-off-by: Bryant Biggs <[email protected]>

bryantbiggs · 2025-08-26T14:34:29Z

cc @Thomasdezeeuw / @Darksonn - any chance on a review?

Thomasdezeeuw · 2025-08-26T14:41:40Z

cc @Thomasdezeeuw / @Darksonn - any chance on a review?

I don't work on this repo :)

I'm sure someone will give it a review though.

reneleonhardt · 2025-08-27T10:20:16Z

I can imagine that your hard work will eventually be reviewed, if not this year then maybe next year 😄

bryantbiggs added 8 commits August 26, 2025 09:22

chore: Update dependencies to latest

9c8abc8

fix: Add AsFd impl for Socket

a5e5c2f

fix: Make clippy happy

e21584e

fix: Add resource feature to nix dev dependency

12a2770

chore: Roll back patch version changes

73760ec

fix: Correct clippy lints for string formatted variable usage

82c24e6

deps: Re-update tempfile and criterion

ae0bb8e

bryantbiggs force-pushed the chore/update-dependencies branch from 75bc736 to ae0bb8e Compare August 26, 2025 14:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Update dependencies and fix clippy warnings #327

chore: Update dependencies and fix clippy warnings #327

Uh oh!

bryantbiggs commented Apr 13, 2025 •

edited

Loading

Uh oh!

bryantbiggs commented Apr 13, 2025

Uh oh!

paolobarbolini commented Apr 25, 2025 •

edited

Loading

Uh oh!

bryantbiggs commented Apr 25, 2025

Uh oh!

paolobarbolini commented Apr 25, 2025

Uh oh!

reneleonhardt commented Jun 30, 2025 •

edited

Loading

Uh oh!

bryantbiggs commented Jun 30, 2025

Uh oh!

tomaszduda23 commented Aug 24, 2025

Uh oh!

tomaszduda23 commented Aug 24, 2025

Uh oh!

bryantbiggs commented Aug 26, 2025

Uh oh!

Thomasdezeeuw commented Aug 26, 2025

Uh oh!

reneleonhardt commented Aug 27, 2025

Uh oh!

Uh oh!

chore: Update dependencies and fix clippy warnings #327

Are you sure you want to change the base?

chore: Update dependencies and fix clippy warnings #327

Uh oh!

Conversation

bryantbiggs commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bryantbiggs commented Apr 13, 2025

Uh oh!

paolobarbolini commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bryantbiggs commented Apr 25, 2025

Uh oh!

paolobarbolini commented Apr 25, 2025

Uh oh!

reneleonhardt commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bryantbiggs commented Jun 30, 2025

Uh oh!

tomaszduda23 commented Aug 24, 2025

Uh oh!

tomaszduda23 commented Aug 24, 2025

Uh oh!

bryantbiggs commented Aug 26, 2025

Uh oh!

Thomasdezeeuw commented Aug 26, 2025

Uh oh!

reneleonhardt commented Aug 27, 2025

Uh oh!

Uh oh!

bryantbiggs commented Apr 13, 2025 •

edited

Loading

paolobarbolini commented Apr 25, 2025 •

edited

Loading

reneleonhardt commented Jun 30, 2025 •

edited

Loading