Skip to content

Conversation

@ADD-SP
Copy link
Member

@ADD-SP ADD-SP commented Oct 4, 2025

See #7653.

We cannot revert 0248697 because of the same issue of socket2 (rust-lang/socket2#616).

error[E0557]: feature has been removed
  --> /home/dev/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/socket2-0.6.0/src/lib.rs:57:29
   |
57 | #![cfg_attr(docsrs, feature(doc_auto_cfg))]
   |                             ^^^^^^^^^^^^ feature has been removed
   |
   = note: removed in CURRENT_RUSTC_VERSION; see <https://github.com/rust-lang/rust/pull/138907> for more information
   = note: merged into `doc_cfg`

@ADD-SP ADD-SP added the A-tokio Area: The main tokio crate label Oct 4, 2025
@Darksonn
Copy link
Contributor

Darksonn commented Oct 4, 2025

Is the bump actually needed? I don't think we run with old dependencies when building docs.

@ADD-SP
Copy link
Member Author

ADD-SP commented Oct 4, 2025

Is the bump actually needed? I don't think we run with old dependencies when building docs.

Ah, you are right.

@ADD-SP ADD-SP closed this Oct 4, 2025
@ADD-SP ADD-SP deleted the add_sp/tokio-bump-parking-lot branch October 4, 2025 10:05
@ADD-SP ADD-SP restored the add_sp/tokio-bump-parking-lot branch October 5, 2025 07:16
@ADD-SP ADD-SP deleted the add_sp/tokio-bump-parking-lot branch October 5, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tokio Area: The main tokio crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants