-
Notifications
You must be signed in to change notification settings - Fork 3
New Application To Match Original #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
tolicodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Just remove commented code. Also set up with chromatic to give me a storybook preview. You can see the other PRs for an example
| export function Description(props: PropsWithChildren<DescriptionProps>) { | ||
| return ( | ||
| <Container> | ||
| {/* <Row> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented code through the PR
|
|
||
| } | ||
|
|
||
| export const Header = (props: HeaderProps) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn’t need its own component
| import styled from "styled-components"; | ||
|
|
||
| const Item = styled.a` | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is invalid
Issues: