Skip to content

Conversation

@ethan-kaseff
Copy link
Collaborator

  • Completed SiteName component.
  • Created structure of the application organizing everything into the App component.
  • Used styled-components for CSS.

Issues:

  • Couldn't get { Row, Col } from '@geist-ui/react' so I commented out to bring functionality.
  • Seeing a problem with anything after 'styled.' like it's saying 'h1' isn't an object on the styled variable.

Copy link
Owner

@tolicodes tolicodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just remove commented code. Also set up with chromatic to give me a storybook preview. You can see the other PRs for an example

export function Description(props: PropsWithChildren<DescriptionProps>) {
return (
<Container>
{/* <Row>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code through the PR


}

export const Header = (props: HeaderProps) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t need its own component

import styled from "styled-components";

const Item = styled.a`
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants