Skip to content

feat: projects #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Agustina-Carrion wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: projects #85

Agustina-Carrion wants to merge 10 commits into from

Conversation

@Agustina-Carrion
Copy link
Member

@Agustina-Carrion Agustina-Carrion commented Feb 7, 2023

Some things i still need to sort styling wise, for example: project headline is a different vector i need to upload and wide card image background needs some tuning. But the bases are there.
Also, i've used some elements from other PR to start implementation (like: LinkWrapper, ContentTransformer)

@Agustina-Carrion Agustina-Carrion temporarily deployed to ionos February 7, 2023 16:17 — with GitHub Actions Inactive
@Agustina-Carrion Agustina-Carrion temporarily deployed to ionos February 7, 2023 16:18 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage

@Agustina-Carrion Agustina-Carrion temporarily deployed to ionos February 8, 2023 09:11 — with GitHub Actions Inactive
@Agustina-Carrion Agustina-Carrion temporarily deployed to ionos February 8, 2023 09:11 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage

pReya
pReya requested changes Feb 8, 2023
View reviewed changes
src/components/LinkWrapper.tsx Outdated
@@ -0,0 +1,4 @@
const LinkWrapper = ({ condition, wrapper, children }) =>
Copy link
Member

@pReya pReya Feb 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the component to ConditionalLinkWrapper?

Copy link
Member

@pReya pReya Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Agustina-Carrion You still have this on your list?

Copy link
Member Author

@Agustina-Carrion Agustina-Carrion Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i'll do this now if you want to continue merging to main. It'll be done in the next minutes

@pReya pReya changed the title feat: projects index feat: projects Feb 8, 2023
@pReya pReya temporarily deployed to ionos February 10, 2023 15:08 — with GitHub Actions Inactive
@pReya pReya temporarily deployed to ionos February 10, 2023 15:09 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 10, 2023

✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage

@Agustina-Carrion Agustina-Carrion temporarily deployed to ionos February 10, 2023 15:24 — with GitHub Actions Inactive
@Agustina-Carrion Agustina-Carrion temporarily deployed to ionos February 10, 2023 15:25 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 10, 2023

✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage

@Agustina-Carrion Agustina-Carrion temporarily deployed to ionos February 10, 2023 16:32 — with GitHub Actions Inactive
@Agustina-Carrion Agustina-Carrion temporarily deployed to ionos February 10, 2023 16:33 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 10, 2023

✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage

@pReya pReya temporarily deployed to ionos May 30, 2023 08:32 — with GitHub Actions Inactive
@pReya pReya temporarily deployed to ionos May 30, 2023 08:32 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented May 30, 2023

✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage

@pReya pReya temporarily deployed to ionos May 30, 2023 08:43 — with GitHub Actions Inactive
@pReya pReya temporarily deployed to ionos May 30, 2023 08:44 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented May 30, 2023

✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage

@pReya pReya temporarily deployed to ionos May 31, 2023 14:29 — with GitHub Actions Inactive
@pReya pReya temporarily deployed to ionos May 31, 2023 14:30 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented May 31, 2023

✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pReya pReya pReya requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Agustina-Carrion @pReya