fix(PM-2662): Show only current users winning submission in winners tab if challenge is private #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return true | ||
| }, [isCompletedDesignChallenge, isSubmissionsViewable, canViewAllSubmissions]) | ||
|
|
||
| const filterFunc = useCallback((submissions: ProjectResult[]): ProjectResult[] => submissions |
There was a problem hiding this comment.
[💡 performance]
The filterFunc function uses useCallback but does not have any dependencies that are functions or objects that could change. Consider using useMemo instead for consistency with other memoized values in this component.
| const filterFunc = useCallback((submissions: ProjectResult[]): ProjectResult[] => submissions | ||
| .filter(submission => { | ||
| if (!canViewSubmissions) { | ||
| return String(submission.userId) === String(loginUserInfo?.userId) |
There was a problem hiding this comment.
[correctness]
The comparison String(submission.userId) === String(loginUserInfo?.userId) could potentially lead to unexpected behavior if userId is null or undefined. Ensure that userId is always a valid string or number before this comparison.
kkartunov
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-2662
What's in this PR?