-
Notifications
You must be signed in to change notification settings - Fork 4
Platform Upgrade -- Wagtail 7.2, Node 24 #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…r 4.15.2 -> 5.2.2
…4 -> 8.2.0 sass-loader 8.0.2 -> 16.0.6
Webpack 5 introduced a built-in output.clean option that provides similar functionality for cleaning the output directory before each build.
…ylelint issues Relative path issues: - Change @use 'config' to @use '../config' in base/ and components/ - Change @use 'config' to @use '../../config' in components/navigation/ Resolves sass-loader module resolution error during build Stylelint issues: 1. **Remove needless stylelint-disable comments** in _grid.scss and _pagination.scss that are no longer needed 2. **Fix @if null check** in _mixins.scss - change from `$variable == null` to `not $variable` (SCSS preferred syntax) 3. **Add interpolation for CSS custom properties** in _variables.scss - wrap all SCSS variables used inside `color.adjust()` with `#{}` 4. Update lint:css script in package.json -- Stylelint should only lint SCSS/CSS files
…0.13.1 -> 0.16.0), boto3 (1.40.18 -> 1.42.5)
nickmoreton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @engineervix You code changes all look good and the UI looks correct locally.
Can you please update the upgrading.md file, there's a couple of Wagtail 7.1 references to bump to 7.2
Thanks @nickmoreton, done in 41edd18 |
Link to Ticket
When applied this MR will
Important
poetry update modelsearchto be sure we pick up the latest modelsearch packageHow to Test
Please see the relevant spreadsheet
Screenshots
Expand to see more
Wagtail 7.2 release notes
Add a link to the commit or file for each consideration if you made any code changes.
Code reviewing a consideration.
Use the tick box to indicate a consideration has been code reviewed as OK
Upgrade considerations - changes affecting all projects
Upgrade considerations - deprecation of old functionality
Upgrade considerations - changes to undocumented internals
All versions extras
Identified by the support team as additional considerations to be checked for all Wagtail upgrades
Additional Considerations
Any other considerations you've made and/or considered.
poetry update modelsearchto be sure we pick up the latest modelsearch packageMR Checklist
Add a description of your pull request and instructions for the reviewer to verify your work.
If your pull request is for a specific ticket, link to it in the description.
Stay on point and keep it small so the merge request can be easily reviewed.
Tests and linting passes.
Added
Not required
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library