Skip to content

fix WebSocketClientConnection circle reference to itself #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix WebSocketClientConnection circle reference to itself #2865

wants to merge 7 commits into from

Conversation

qcha0
Copy link
Contributor

@qcha0 qcha0 commented May 20, 2020

No description provided.

bdarnell
bdarnell reviewed Jun 19, 2020
View reviewed changes
Copy link
Member

@bdarnell bdarnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mypy annotations need updating to reflect that this attribute is now optional.

I wish Future were actually two types, one for the setters and one for the getters.

@qcha0 qcha0 force-pushed the hotfix/break-reference-websocket-itself branch from e932d0d to 8564b21 Compare November 13, 2021 04:52
@qcha0 qcha0 force-pushed the hotfix/break-reference-websocket-itself branch from 8564b21 to 84cc2a1 Compare October 10, 2023 09:22
@qcha0 qcha0 force-pushed the hotfix/break-reference-websocket-itself branch from 33e1dc0 to 0087604 Compare October 10, 2023 09:55
@qcha0 qcha0 force-pushed the hotfix/break-reference-websocket-itself branch from 0087604 to 5296bd8 Compare October 10, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdarnell bdarnell bdarnell left review comments

Assignees

No one assigned

Labels

websocket

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qcha0 @bdarnell