Prefer emitting indirect calls if possible #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EDIT: it was a misunderstanding on my part |
|
This is a (partial?) list of failing builds when passing -k 0 using Henrik's branch against instafix-llvm main: This is the same list, but against my instafix-llvm branch: These tests fail to build on main but succeed on my branch: No packages fail to build on my branch but succeed on main AFAICT |
ekilmer
added a commit
to trail-of-forks/instafix-llvm-test-suite
that referenced
this pull request
Jun 6, 2025
trailofbits/instafix-llvm#44 is an attempted workaround for some ill-formed C programs that we still need to support building, but it will cause way more LLVM indirect calls to be generated, and calls to be generated with the wrong number of arguments against the original declaration Essentially, the issue is that some programs do ```c int foo() { ... } ``` Then somewhere else: ```c extern int foo(int bar); foo(0); ```
ekilmer
added a commit
to trail-of-forks/instafix-llvm-test-suite
that referenced
this pull request
Jun 6, 2025
trailofbits/instafix-llvm#44 is an attempted workaround for some ill-formed C programs that we still need to support building, but it will cause way more LLVM indirect calls to be generated, and calls to be generated with the wrong number of arguments against the original declaration Essentially, the issue is that some programs do ```c int foo() { ... } ``` Then somewhere else: ```c extern int foo(int bar); foo(0); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hack in order to make the
lencodtest compileNOTE(ekilmer, June 9): Let's hold off on merging this until we understand the consequences of how this affects static analysis results. We can skip the affected tests in the meantime.