Skip to content

Fixes a bug when reversing consecutive jumps #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes a bug when reversing consecutive jumps #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion R/functions_corr.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,13 @@ reversecorr <- function(data_L1, data_L2, reverse, tz) {

# reverse differences
if (grepl("jump", flag_old[rev])) {
val[rev:length(val)] <- val[rev:length(val)] + diff_L1[rev]
# if two or more jumps are consecutive, the difference value is accumulated
# so when undoing / reversing one of the jumps is equivalent to reversing
# altogether. This might have a better fix, but for now let's skip when
# there's more than one jump together. Maybe it happens with outliers too?
if (!(r > 1 && rev == reverse_row[r-1]+1)) { # Check the time instant is not the successor of the previous one. so they are consecutive.
val[rev:length(val)] <- val[rev:length(val)] + diff_L1[rev]
}
}
# restore deleted values
if (grepl("out", flag_old[rev])) {
Expand Down