Add license support to helm chart #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@idanovo this should be updated before releasing no-fluffy |
Isan-Rivkin
requested changes
Jul 8, 2025
N-o-Z
force-pushed
the
task/add-license-support-to-chart-344
branch
3 times, most recently
from
d512586 to
799fd0d
Compare
|
@Isan-Rivkin rebased after fluffy deprecation. Please review new code |
N-o-Z
force-pushed
the
task/add-license-support-to-chart-344
branch
from
799fd0d to
79dc35b
Compare
Isan-Rivkin
reviewed
Jul 16, 2025
Isan-Rivkin
requested changes
Jul 16, 2025
Isan-Rivkin
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
@N-o-Z Thanks!
Left 1 important comment but everything else LGTM!
Approving to make sure it's not blocking over the weekend but please notice it since this will not "compile" when using existing secret.
charts/lakefs/templates/_env.tpl
Outdated
| {{- if and .Values.existingSecret .Values.secretKeys.licenseContentsKey }} | ||
| - name: secret-volume-license-token | ||
| secret: | ||
| secretName: secretName: {{ .Values.existingSecret }} |
There was a problem hiding this comment.
Suggested change
| secretName: secretName: {{ .Values.existingSecret }} | |
| secretName: {{ .Values.existingSecret }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #344