Skip to content

Improves large output messaging #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025
Merged

Improves large output messaging #2341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33ce0fa
Adds more information to the large payloads/outputs
samejr Aug 2, 2025
c2bcc3d
Changes the Download logs button to secondary
samejr Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions apps/webapp/app/components/runs/v3/PacketDisplay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import { CloudArrowDownIcon } from "@heroicons/react/20/solid";
import { CodeBlock } from "~/components/code/CodeBlock";
import { InlineCode } from "~/components/code/InlineCode";
import { LinkButton } from "~/components/primitives/Buttons";
import { Header3 } from "~/components/primitives/Headers";
import { Paragraph } from "~/components/primitives/Paragraph";
import { TextLink } from "~/components/primitives/TextLink";
import { docsPath } from "~/utils/pathBuilder";

export function PacketDisplay({
data,
Expand All @@ -15,13 +19,26 @@ export function PacketDisplay({
switch (dataType) {
case "application/store": {
return (
<div className="flex flex-col">
<Paragraph variant="base/bright" className="w-full py-2.5 text-sm">
{title}
<div className="mt-2 flex flex-col">
<Header3>{title}</Header3>
<Paragraph variant="small" className="mb-2">
This {title.toLowerCase()} exceeded the size limit and was automatically offloaded to
object storage. You can retrieve it using{" "}
<InlineCode variant="extra-small">runs.retrieve</InlineCode> or download it directly
below. <TextLink to={docsPath("limits#task-payloads-and-outputs")}>Learn more</TextLink>
.
</Paragraph>
<LinkButton LeadingIcon={CloudArrowDownIcon} to={data} variant="tertiary/medium" download>
Download
</LinkButton>
<div>
<LinkButton
LeadingIcon={CloudArrowDownIcon}
to={data}
variant="secondary/small"
download
className="inline-flex text-text-bright"
>
Download {title.toLowerCase()}
</LinkButton>
</div>
</div>
);
}
Expand Down
6 changes: 3 additions & 3 deletions ...zationSlug.projects.$projectParam.env.$envParam.runs.$runParam.spans.$spanParam/route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {
import { type LoaderFunctionArgs } from "@remix-run/server-runtime";
import {
formatDurationMilliseconds,
MachinePresetName,
type TaskRunError,
taskRunErrorEnhancer,
} from "@trigger.dev/core/v3";
Expand Down Expand Up @@ -804,14 +803,15 @@ function RunBody({
{run.isCached ? "Jump to original run" : "Focus on run"}
</LinkButton>
)}
<AdminDebugRun friendlyId={run.friendlyId} />
</div>
<AdminDebugRun friendlyId={run.friendlyId} />
<div className="flex items-center gap-4">
{run.logsDeletedAt === null ? (
<LinkButton
to={v3RunDownloadLogsPath({ friendlyId: runParam })}
LeadingIcon={CloudArrowDownIcon}
variant="tertiary/medium"
leadingIconClassName="text-indigo-400"
variant="secondary/medium"
target="_blank"
download
>
Expand Down
Loading