Additional files docs with legacyDevProcessCwdBehaviour

[matt-aitken]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: bdda691

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

• Updated docs/config/extensions/additionalFiles.mdx
• Documented new configuration option legacyDevProcessCwdBehaviour: false, noting default is true
• Revised build.extensions example to use files: ["./assets/", "wrangler/wrangler.toml"] and removed prior "./fonts/" order
• Added snippet illustrating use of process.cwd() when legacyDevProcessCwdBehaviour is false (e.g., joining to assets/Inter-Regular.ttf)
• Clarified that files are copied to the build directory and that the root project directory is where trigger.config.ts resides

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	No pull request description was provided and the repository's required template was not followed, so required sections like "Closes #", the checklist, Testing steps, and Changelog are missing, preventing verification of testing and intent.	Please populate the PR using the repository template: add "Closes #", complete the checklist, provide the Testing steps you ran, include a short Changelog entry, and attach any relevant screenshots or verification notes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "Additional files docs with legacyDevProcessCwdBehaviour" clearly references the primary change in the diff: documentation updates for additional files and the new legacyDevProcessCwdBehaviour option, and it is concise and specific enough for a reviewer to understand the main intent.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch additional-files-docs

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

docs/config/extensions/additionalFiles.mdx (3)

16-18: Clarify default/scope and caution existing projects

• Confirm the default is indeed true in the current release and that this flag only changes dev-time CWD (not deploy).
• Consider adding a brief note that flipping this may break path assumptions in existing projects; recommend for new projects first.

Suggested addition:

   // We strongly recommend setting this to false
   // When set to `false`, the current working directory will be set to the build directory, which more closely matches production behavior.
   legacyDevProcessCwdBehaviour: false, // Default: true
+  // Note: Changing this may break existing dev setups that rely on process.cwd() pointing to the project root.
+  // We recommend enabling this for new projects or after auditing file path usage.

---

20-20: Normalize path style in example for consistency

Use consistent leading "./" (or omit it for both). This avoids reader confusion about relative path handling.

-    extensions: [additionalFiles({ files: ["./assets/**", "wrangler/wrangler.toml"] })],
+    extensions: [additionalFiles({ files: ["./assets/**", "./wrangler/wrangler.toml"] })],

---

29-36: Good, but add a usage hint

Snippet is solid. Consider showing a quick fs read example to make the intention explicit.

 import path from "node:path";

 // You can use `process.cwd()` if you use `legacyDevProcessCwdBehaviour: false`
 const interRegularFont = path.join(process.cwd(), "assets/Inter-Regular.ttf");
+// e.g. read at runtime:
+// import fs from "node:fs";
+// const fontBuffer = fs.readFileSync(interRegularFont);

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 412e80f and bdda691.

📒 Files selected for processing (1)

• docs/config/extensions/additionalFiles.mdx (2 hunks)

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-08-18T10:07:17.368Z
Learning: Applies to trigger.config.ts : Declare build options and extensions (external, jsx, conditions, extensions) via the build block in trigger.config.ts rather than custom scripts

📚 Learning: 2025-08-18T10:07:17.368Z

Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-08-18T10:07:17.368Z
Learning: Applies to trigger.config.ts : Provide a valid Trigger.dev configuration using defineConfig with project ref and dirs (e.g., ["./trigger"]; tests/specs auto-excluded)

Applied to files:

• docs/config/extensions/additionalFiles.mdx

📚 Learning: 2025-08-18T10:07:17.368Z

Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-08-18T10:07:17.368Z
Learning: Applies to trigger.config.ts : Declare build options and extensions (external, jsx, conditions, extensions) via the build block in trigger.config.ts rather than custom scripts

Applied to files:

• docs/config/extensions/additionalFiles.mdx

📚 Learning: 2025-08-29T10:06:49.293Z

Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025-08-29T10:06:49.293Z
Learning: Applies to apps/webapp/**/*.{ts,tsx} : When importing from trigger.dev/core in the webapp, never import the root package path; always use one of the documented subpath exports from trigger.dev/core’s package.json

Applied to files:

• docs/config/extensions/additionalFiles.mdx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (javascript-typescript)