Skip to content

Add Pod Disruption Budget support to Trino chart #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Pod Disruption Budget support to Trino chart #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions charts/trino/templates/poddisruptionbudget-coordinator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{{- with .Values.coordinator.podDisruptionBudget }}
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
name: {{ include "trino.coordinator" $ }}
namespace: {{ $.Release.Namespace }}
labels:
{{- include "trino.labels" $ | nindent 4 }}
app.kubernetes.io/component: coordinator
spec:
selector:
matchLabels:
{{- include "trino.selectorLabels" $ | nindent 6 }}
app.kubernetes.io/component: coordinator
{{- toYaml . | nindent 2 }}
{{- end }}
18 changes: 18 additions & 0 deletions charts/trino/templates/poddisruptionbudget-worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{{- if gt (int .Values.server.workers) 0 }}
{{- with .Values.worker.podDisruptionBudget }}
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
name: {{ include "trino.worker" $ }}
namespace: {{ $.Release.Namespace }}
labels:
{{- include "trino.labels" $ | nindent 4 }}
app.kubernetes.io/component: worker
spec:
selector:
matchLabels:
{{- include "trino.selectorLabels" $ | nindent 6 }}
app.kubernetes.io/component: worker
{{- toYaml . | nindent 2 }}
{{- end }}
{{- end }}
24 changes: 24 additions & 0 deletions charts/trino/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,18 @@ coordinator:
maxUnavailable: 25%
# coordinator.deployment.strategy -- The deployment strategy to use to replace existing pods with new ones.

podDisruptionBudget: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set these values in the complete values test, so we know the chart renders correctly.

# coordinator.podDisruptionBudget -- [Pod Disruption Budget](https://kubernetes.io/docs/concepts/workloads/pods/disruptions/#pod-disruption-budgets) configuration.
# @raw
# Example:
# ```yaml
# minAvailable: 1
# ```
# or
# ```yaml
# maxUnavailable: 1
# ```

jvm:
maxHeapSize: "8G"
gcMethod:
Expand Down Expand Up @@ -797,6 +809,18 @@ worker:
maxUnavailable: 25%
# worker.deployment.strategy -- The deployment strategy to use to replace existing pods with new ones.

podDisruptionBudget: {}
# worker.podDisruptionBudget -- [Pod Disruption Budget](https://kubernetes.io/docs/concepts/workloads/pods/disruptions/#pod-disruption-budgets) configuration.
# @raw
# Example:
# ```yaml
# maxUnavailable: 1
# ```
# or
# ```yaml
# minAvailable: 2
# ```

jvm:
maxHeapSize: "8G"
gcMethod:
Expand Down
Loading