Resource Group pattern matching on client tags #26328
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjian2664
reviewed
Aug 2, 2025
| @@ -90,8 +91,12 @@ public StaticSelector( | |||
| new BasicMatcher(criteria -> queryTypeValue.equalsIgnoreCase(criteria.getQueryType().orElse(""))))) | |||
| .add(selectorResourceEstimate.map(selectorResourceEstimateValue -> | |||
| new BasicMatcher(criteria -> selectorResourceEstimateValue.match(criteria.getResourceEstimates())))) | |||
| .add(clientTags.map(clientTagsValue -> | |||
| new BasicMatcher(criteria -> criteria.getTags().containsAll(clientTagsValue)))) | |||
| .add(clientTags.map(tags -> { | |||
There was a problem hiding this comment.
Could this be a breaking change if users previously used client tags containing special characters (like *) that are interpreted in regex
| @@ -212,6 +212,46 @@ public void testClientTags() | |||
| assertThat(selector.match(newSelectionCriteria("A.user", "a source b", ImmutableSet.of("tag1", "tag2", "tag3"), EMPTY_RESOURCE_ESTIMATES)).map(SelectionContext::getResourceGroupId)).isEqualTo(Optional.of(resourceGroupId)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testClientTagsRegex() | |||
jinyangli34
force-pushed
the
jinyang-client_tags_pattern
branch
from
1b96843 to
c3cf480
Compare
jinyangli34
force-pushed
the
jinyang-client_tags_pattern
branch
from
c3cf480 to
9c43cc0
Compare
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for resource group selector pattern matching on client tags
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: