Skip to content

Conversation

tbaeg
Copy link
Member

@tbaeg tbaeg commented Sep 29, 2025

Description

During partition column construction, the referenced field(s) were not in the correct order which could cause IllegalArgumentException.

The FilesTablePageSource was updated to use field id look ups instead of relying solely on order.

java.lang.IllegalArgumentException: Wrong class, expected java.lang.CharSequence, but was java.lang.Boolean, for object: true
        at org.apache.iceberg.PartitionData.get(PartitionData.java:126)
        at io.trino.plugin.iceberg.system.files.FilesTablePageSource.lambda$getNextSourcePage$2(FilesTablePageSource.java:211)
        at io.trino.spi.block.RowBlockBuilder.buildEntry(RowBlockBuilder.java:111)
        at io.trino.plugin.iceberg.system.files.FilesTablePageSource.getNextSourcePage(FilesTablePageSource.java:204)
        at io.trino.operator.TableScanOperator.getOutput(TableScanOperator.java:262)
        at io.trino.operator.Driver.processInternal(Driver.java:403)
        at io.trino.operator.Driver.lambda$process$0(Driver.java:306)
        at io.trino.operator.Driver.tryWithLock(Driver.java:709)
        at io.trino.operator.Driver.process(Driver.java:298)
        at io.trino.operator.Driver.processForDuration(Driver.java:269)
        at io.trino.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:851)
        at io.trino.execution.executor.dedicated.SplitProcessor.run(SplitProcessor.java:77)
        at io.trino.execution.executor.dedicated.TaskEntry$VersionEmbedderBridge.lambda$run$0(TaskEntry.java:205)
        at io.trino.$gen.Trino_477_4_g3fee187____20250925_141258_2.run(Unknown Source)
        at io.trino.execution.executor.dedicated.TaskEntry$VersionEmbedderBridge.run(TaskEntry.java:206)
        at io.trino.execution.executor.scheduler.FairScheduler.runTask(FairScheduler.java:177)
        at io.trino.execution.executor.scheduler.FairScheduler.lambda$submit$0(FairScheduler.java:164)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:545)
        at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:128)
        at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:74)
        at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:80)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1095)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:619)
        at java.base/java.lang.Thread.run(Thread.java:1447)

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@tbaeg tbaeg requested a review from raunaqmorarka September 29, 2025 14:54
@cla-bot cla-bot bot added the cla-signed label Sep 29, 2025
@github-actions github-actions bot added the iceberg Iceberg connector label Sep 29, 2025
During partition column construction, the
referenced field(s) were not in the correct
order which could cause IllegalArgumentException.

The FilesTablePageSource was updated to use field
id look ups instead of relying solely on order.
Copy link
Member

@raunaqmorarka raunaqmorarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a regression from recent changes, or was it broken before as well ?

@tbaeg
Copy link
Member Author

tbaeg commented Sep 30, 2025

Is this a regression from recent changes, or was it broken before as well ?

I think it has always been an issue since the logic wasn't changed much from the previous implementation. When I get a chance I can verify.

@tbaeg
Copy link
Member Author

tbaeg commented Oct 1, 2025

Ran the same test on 476, and it passed; looks like it is a regression.

@tbaeg
Copy link
Member Author

tbaeg commented Oct 7, 2025

@ebyhr @chenjian2664 Gentle reminder.

@tbaeg tbaeg added the bug Something isn't working label Oct 7, 2025
@ebyhr ebyhr removed the bug Something isn't working label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

3 participants