Remove deprecated.omit-datetime-type-precision config property #27501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjian2664
approved these changes
Nov 28, 2025
findepi
force-pushed
the
findepi/remove-deprecated-omit-datetime-type-precision-config-property-29674c
branch
from
d34c8a3 to
c112a3c
Compare
It was initially added next to other enums, but now they are gone. Move to a better place.
Test `time` also in `omit_datetime_type_precision=false` case.
The oldest tested version is 352 (`first_tested_version=352` in `run_tests.sh`), so version-inspecting functions are effectively constants.
This property was added 5 years ago to support old clients. It's not going to stay for ever.
findepi
force-pushed
the
findepi/remove-deprecated-omit-datetime-type-precision-config-property-29674c
branch
from
c112a3c to
5d98742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property was added 5 years ago to support old clients. It's not going to stay for ever.
release notes
Does removing a deprecated property need mention in RNs?
I think it doesn't. it should be assumed that there was a mention when property was deprecated.