Add missing defaultValue for ColumnMetadata.Builder #27503
+48
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
fix/default_value
branch
from
9273946 to
1122d81
Compare
ebyhr
approved these changes
Nov 28, 2025
findepi
reviewed
Nov 28, 2025
| { | ||
| this.name = columnMetadata.getName(); | ||
| this.type = columnMetadata.getType(); | ||
| this.defaultValue = columnMetadata.getDefaultValue(); |
Member
There was a problem hiding this comment.
just this.defaultValue = columnMetadata.getDefaultValue(); is enough (pushed a fix to your branch)
can you please add a test that Builder(ColumnMetada).build() roundtrips?
hqbhoho
force-pushed
the
fix/default_value
branch
from
1122d81 to
2ac0aca
Compare
findepi
reviewed
Nov 28, 2025
Comment on lines
29
to
38
| ColumnMetadata originColumnMetadata = ColumnMetadata.builder() | ||
| .setName("test_column") | ||
| .setType(INTEGER) | ||
| .setDefaultValue(Optional.of("1")) | ||
| .setNullable(false) | ||
| .setComment(Optional.ofNullable("test_comment")) | ||
| .setExtraInfo(Optional.of("test_extra_info")) | ||
| .setHidden(false) | ||
| .setProperties(ImmutableMap.of("test_key", "test_value")) | ||
| .build(); |
Member
There was a problem hiding this comment.
Make ColumnMetadata constructor package private, @VisibleForTesting and call here.
This would ensure the test stays up to date, should there any new fields be added.
Contributor
Author
There was a problem hiding this comment.
ok, @VisibleForTesting will need guava dependency. I add a doc rather than add dependency. what do you think?
hqbhoho
force-pushed
the
fix/default_value
branch
from
2ac0aca to
de3fbce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing defaultValue for ColumnMetadata.Builder
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.