refactor: Making tritonclient.http and tritonclient.grpc health checks uniform
#814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to address a silent error not being caught in
tritonclient.http.is_server_live()andtritonclient.http.is_server_ready().Currently if we start a tritonserver instance with a health restricted feature specification, with the following command:
Then if we use
tritonclientto query for health information, we receive the following:From the above example, we can see that
tritonclientprovides different behavior forgrpcandhttpin terms of erroring out when invalid credentials are presented.