feat: add lldap application for community catalog #3946
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavros-k
reviewed
Dec 25, 2025
| port_number: 3890 | ||
| storage: | ||
| data: | ||
| path: /tmp/lldap-test |
stavros-k
requested changes
Dec 25, 2025
Contributor
stavros-k
left a comment
stavros-k
left a comment
There was a problem hiding this comment.
Sorry but this follows zero styles from other apps.
I'm gonna close it for now as you also didnt open an issue to discuss and assign it to you first.
Thanks
| type: host_path | ||
| host_path_config: | ||
| path: /tmp/lldap-test | ||
| storage_defaults: |
| type: host_path | ||
| host_path_config: | ||
| path: /tmp/lldap-test | ||
| test_random_key: RAND68SG6w8PI2YS |
| @@ -0,0 +1,23 @@ | |||
| settings: | |||
Contributor
There was a problem hiding this comment.
where is the resources section?
| {% set tpl = ix_lib.base.render.Render(values) %} | ||
|
|
||
| {% set consts = values.consts %} | ||
| {% set container = tpl.add_container(consts.container_name, "main") %} |
Contributor
There was a problem hiding this comment.
default image MUST be named image
Comment on lines
+16
to
+17
| {% do container.clear_caps() %} | ||
| {% do container.deploy.resources.remove_cpus_and_memory() %} |
Comment on lines
+8
to
+29
| values: | ||
| settings: | ||
| domain: example.com | ||
| admin_user: admin | ||
| networking: | ||
| web_port: | ||
| bind_mode: published | ||
| port_number: 17170 | ||
| ldap_port: | ||
| bind_mode: published | ||
| port_number: 3890 | ||
| storage: | ||
| data: | ||
| path: /mnt/tank/apps/lldap | ||
| type: host_path | ||
| host_path_config: | ||
| path: /mnt/tank/apps/lldap | ||
| secrets: | ||
| admin_password: | ||
| random: true | ||
| jwt_secret: | ||
| random: true |
Comment on lines
+30
to
+41
| notes: | ||
| - title: Credentials | ||
| level: INFO | ||
| message: 'Default admin username is admin. Set the password during installation. | ||
|
|
||
| ' | ||
| storage_defaults: | ||
| data: | ||
| type: host_path | ||
| host_path_config: | ||
| path: /mnt/tank/apps/lldap | ||
| create_host_path: true |
Comment on lines
+3
to
+8
| - name: LLDAP | ||
| description: Configure the directory server | ||
| - name: Networking | ||
| description: Configure external access | ||
| - name: Storage | ||
| description: Configure data persistence |
Contributor
There was a problem hiding this comment.
I'm missing user, resources and labels group.
Comment on lines
+61
to
+68
| - variable: port_number | ||
| label: Port Number | ||
| schema: | ||
| type: int | ||
| default: 17170 | ||
| min: 1 | ||
| max: 65535 | ||
| required: true |
Comment on lines
+95
to
+109
| - variable: storage | ||
| group: Storage | ||
| label: Data Storage | ||
| schema: | ||
| type: dict | ||
| attrs: | ||
| - variable: data | ||
| label: Data Directory | ||
| schema: | ||
| type: hostPath | ||
| attrs: | ||
| - variable: path | ||
| type: path | ||
| default: /mnt/tank/apps/lldap | ||
| required: true |
Contributor
There was a problem hiding this comment.
where is additional storage?, where is other storage types?
Contributor
|
Sorry but this follows almost zero styles from any other app. |
Author
Thanks much for your detailed review. I've re-submitted in #3951 which should align to your guidance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App Addition
Description
Adds LLDAP to the community train.
Lightweight LDAP and authentication server with a built-in web UI for managing users, groups, and application credentials.
App Information
Testing
Tested locally with:
All tests passed successfully.
Icons and Screenshots
Icon: https://cdn.jsdelivr.net/gh/selfhst/icons@main/svg/lldap-light.svg
Screenshot (optional): (not provided)
Special Notes
Checklist