Windows and Python 3.9 compatibility #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed duplicate value (",") from hcatThoroughCombinatorMasks.
Added elif clause and some variables e.g. for the splitlen folder/files and directory separator for Windows compatibility. Replaced all os.mkdir with os.makedirs for creating all the intermediate directories if they don’t exist.
Added module codecs and switched from iso-8859-9 to utf-8 to support and display umlauts on Windows correctly. Added if/elif clause and some variables e.g. for quotes and directory separator for Windows compatibility. Modified hcatMiddleCombinator() and hcatThoroughCombinator() to support multiple character masks on Windows. Added support for multiple single quote characters as a mask on Linux. Modified quick_crack() to avoid a syntax warning message on Python 3.8+ when identity checks (is and is not) are used with certain types of literals (e.g. strings, numbers).
Added comments for Windows users. Maybe this should be added to the readme.md instead.
Replaced all string.lowercase with string.ascii_lowercase for Python 3.x compatibility. Replaced all string.uppercase with string.ascii_uppercase for Python 3.x compatibility. Replaced all iteritems() with items() for Python 3.x compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, I'm not a programmer at all, but I really like the hate_crack project and wanted to use it on my Windows system with Python 3.9. So I built a version which supports both Linux and Windows systems. I also added support for multiple single quote characters as a mask on Linux systems.