Skip to content

increase jobs runner default priority #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

increase jobs runner default priority #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f895e0
improve default pod priorities
lukeviens Jul 11, 2025
ac6bb3d
bump version
lukeviens Jul 14, 2025
77f003e
update logic & note
lukeviens Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/retool/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: retool
description: A Helm chart for Kubernetes
type: application
version: 6.6.0
version: 6.6.1
maintainers:
- name: Retool Engineering
email: [email protected]
Expand Down
4 changes: 3 additions & 1 deletion charts/retool/templates/deployment_backend.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ spec:
spec:
serviceAccountName: {{ template "retool.serviceAccountName" . }}
{{- if .Values.priorityClassName }}
priorityClassName: "{{ .Values.priorityClassName }}"
priorityClassName: {{ .Values.priorityClassName | quote }}
{{- else }}
priorityClassName: {{ printf "%s-backend-priority" (include "retool.fullname" .) | quote }}
{{- end }}
{{- with .Values.hostAliases }}
hostAliases:
Expand Down
4 changes: 3 additions & 1 deletion charts/retool/templates/deployment_jobs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ spec:
spec:
serviceAccountName: {{ template "retool.serviceAccountName" . }}
{{- if .Values.priorityClassName }}
priorityClassName: "{{ .Values.priorityClassName }}"
priorityClassName: {{ .Values.priorityClassName | quote }}
{{- else }}
priorityClassName: {{ printf "%s-jobs-runner-priority" (include "retool.fullname" .) | quote }}
{{- end }}
{{- if .Values.initContainers }}
initContainers:
Expand Down
27 changes: 27 additions & 0 deletions charts/retool/templates/priorityclass.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{{/* We ensure that the jobs runner has highest priority,
since unrun db migrations can lead to pod crashloops. */}}
{{- if not .Values.priorityClassName }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth a comment explaining why we're intentionally deprioritizing backend here

{{- if include "retool.jobRunner.enabled" . }}
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
name: {{ include "retool.fullname" . }}-jobs-runner-priority
labels:
{{- include "retool.labels" . | nindent 4 }}
value: 20
preemptionPolicy: Never
globalDefault: false
description: "PriorityClass for Retool jobs-runner pods"
---
{{- end }}
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
name: {{ include "retool.fullname" . }}-backend-priority
labels:
{{- include "retool.labels" . | nindent 4 }}
value: 10
preemptionPolicy: Never
globalDefault: false
description: "PriorityClass for Retool backend pods"
{{- end }}
Loading