Add Sleep RSSI Feature to Manage Display Sleep Based on Bluetooth Signal Strength #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced sleepRSSI menu to allow the display to sleep based on Bluetooth signal strength. - Updated BLE class to include a sleepRSSI property. - Updated localization files to include "sleep_rssi". Note: As mentioned in ts1#84, the original code's display sleep functionality does not appear to work as expected. This commit does not modify that logic and continues to use the original implementation. Signed-off-by: Noah <[email protected]>
Signed-off-by: Noah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to manage display sleep behavior based on RSSI (Received Signal Strength Indicator) thresholds in the
BLEUnlockapplication. The key changes include adding a "Sleep RSSI" menu, updating the logic to handle display sleep based on RSSI, and extending localization files to support the new feature.Close #153
Warning
As mentioned in #84, the original code's display sleep functionality does not appear to work as expected.
This pull request does not modify that logic and continues to use the original implementation.
Feature Addition: Sleep RSSI Menu
sleepRSSIMenuto the app, along with logic to manage its state and validate menu items based on RSSI thresholds. (BLEUnlock/AppDelegate.swift: [1] [2] [3]BLEUnlock/AppDelegate.swift: BLEUnlock/AppDelegate.swiftR248-R254)setSleepRSSIto handle updates to the "Sleep RSSI" value and persist it in user preferences. (BLEUnlock/AppDelegate.swift: BLEUnlock/AppDelegate.swiftR523-R528)BLEUnlock/AppDelegate.swift: BLEUnlock/AppDelegate.swiftR725-R728)sleepRSSIto theBLEclass to store the RSSI threshold for triggering display sleep. (BLEUnlock/BLE.swift: BLEUnlock/BLE.swiftR132)Localization Updates
BLEUnlock/Base.lproj/Localizable.strings: BLEUnlock/Base.lproj/Localizable.stringsR39)BLEUnlock/da.lproj/Localizable.strings: BLEUnlock/da.lproj/Localizable.stringsR39)BLEUnlock/de.lproj/Localizable.strings: BLEUnlock/de.lproj/Localizable.stringsR39)BLEUnlock/ja.lproj/Localizable.strings: BLEUnlock/ja.lproj/Localizable.stringsR39)BLEUnlock/nb.lproj/Localizable.strings: BLEUnlock/nb.lproj/Localizable.stringsR39)BLEUnlock/sv.lproj/Localizable.strings: BLEUnlock/sv.lproj/Localizable.stringsR39)BLEUnlock/tr.lproj/Localizable.strings: BLEUnlock/tr.lproj/Localizable.stringsR39)BLEUnlock/zh-Hans.lproj/Localizable.strings: BLEUnlock/zh-Hans.lproj/Localizable.stringsR39)