Skip to content

Conversation

@Quanta-Naut
Copy link

I discovered issue where the rendered name appeared flipped and also the entire x-axis being flipped. This was caused by the x-axis being inverted during rendering. I’ve made the necessary adjustments to correct this behaviour.

The Last PR had conflicts so closed that, and now created new PR, to clean up.

@vercel
Copy link

vercel bot commented Oct 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
circuit-json-to-gltf Ready Ready Preview Comment Oct 31, 2025 4:46pm

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs proof of fix with asymmetric positioning, with symmetric positioning it's impossible to know if the texture was flipped or reflected

create 3 leds, each led should have it's position in it's name L0_0, L5_5, L5_0 (i.e. LX_Y)

@Quanta-Naut
Copy link
Author

Ahhhh, that would be a better way to test it, will do that.

@Quanta-Naut
Copy link
Author

After fix Before fix

Left: After fix     |     Right: Before fix

@Quanta-Naut
Copy link
Author

@seveibar the test is failing because the font is different in the test environment, took a while to figure that out, let me know if I can fix it. Thanks.

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • need to show bottom side texture
  • it's still unclear if the model or texture is being flipped but i suspect the entire model is being flipped based on the code.

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea if you're flipping the entire model (which might be ok) a post-transformation fix is not appropriate

@seveibar
Copy link
Contributor

seveibar commented Oct 20, 2025

basically there's a bug somewhere in the code with how the orientations are originally being created. Instead of fixing that, you're just flipping them all (which is inefficient and confusing!)

@Quanta-Naut
Copy link
Author

Top Bottom
Top                                                    Bottom

@Quanta-Naut
Copy link
Author

Top Bottom
Top                                                    Bottom

@Quanta-Naut
Copy link
Author

@seveibar sorry for the delay, had my exams going on. You were right about the bug, I removed the extra layer of transform and focused on fixing the bug, and also added the top and bottom view of a sample circuit.

@Quanta-Naut Quanta-Naut requested a review from seveibar October 30, 2025 16:20
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the transformMesh function is now "lying" and manipulating the input translation. You should be able to flip the texture without flipping the mesh

@seveibar
Copy link
Contributor

@Quanta-Naut i investigated flipping the texture in https://github.com/tscircuit/circuit-json-to-gltf/pull/69/files

It doesn't work- you're correct that the X axis needs to be flipped but your placement of that flipping is not correct. But the good news is your approach is correct

@Quanta-Naut
Copy link
Author

@seveibar Thank you for the confirmation. I have a doubt tho, by wrong placement you mean withing the geometry.ts file or the bug must be fixed in a different file??

@seveibar
Copy link
Contributor

@Quanta-Naut this was patched yesterday!

You can look at the PR here: #70

/tip $20

@algora-pbc
Copy link

algora-pbc bot commented Oct 31, 2025

🎉🎈 @Quanta-Naut has been awarded $20 by tscircuit! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants