feat: implement group constraints for relative layout mode (#1391) #1560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements GitHub issue tscircuit#1391 - adds support for constraint components between groups with xDist, yDist, centerX, and centerY properties. Key features: - Group-to-group constraint detection in Board component - Kiwi solver integration for mathematical constraint solving - Support for distance and center positioning constraints - Comprehensive test suite with 5 test cases - Backward compatibility maintained Changes: - Enhanced Board.ts with doInitialPcbLayout override - Modified applyComponentConstraintClusters.ts for group selector support - Added comprehensive test suite in tests/features/group-constraints/ - Added documentation in GROUP_CONSTRAINTS_README.md Fixes tscircuit#1391
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
454
to
456
| return selectors.some(selector => { | ||
| if (!selector.startsWith(".")) return false | ||
| const name = selector.slice(1) |
There was a problem hiding this comment.
Consider adding a null/undefined check before calling startsWith() to prevent potential runtime errors:
if (!selector || !selector.startsWith(".")) return falseThis defensive check ensures the code handles cases where a selector might be undefined or null, which could happen with optional constraint properties.
Suggested change
| return selectors.some(selector => { | |
| if (!selector.startsWith(".")) return false | |
| const name = selector.slice(1) | |
| return selectors.some(selector => { | |
| if (!selector || !selector.startsWith(".")) return false | |
| const name = selector.slice(1) |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
- Fix TypeScript type narrowing error in Board.ts filter callback - Add null check for selector.startsWith() to prevent runtime errors - Add comprehensive ConstraintProps type extensions for centerX/centerY - Include all missing constraint properties in type declarations - Fix formatting issues with Biome formatter Resolves CI failures in type-check, format, and smoke-test jobs.
|
Hi sir @abimaelmartell , @seveibar , @ricohageman , @imrishabh18 .. ready for review .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements GitHub issue #1391 by adding support for constraint components between groups in relative layout mode.
Key Features
Implementation Details
Core Changes
Technical Approach
Fixes #1391