Fix trace issue with KiCad footprints #1582
Open
+61
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
tests/components/primitive-components/trace-pcb-path-selectors.test.tsx
Outdated
Show resolved
Hide resolved
seveibar
reviewed
Oct 24, 2025
| if (this._hasIncompleteAsyncEffectsInSubtreeForPhase(depPhase)) { | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
i'm confused because this should be handled on line 310
There was a problem hiding this comment.
Yes, there are incomplete async effects from both the immediately previous phase and the declared dependency phases.
but here we’re checking the declared dependency phases within the subtree before recursing into the child nodes
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
@techmannih what's the progress on this? |
|
Yes, It’s still working even after I removed it from line 311. I need to dig in. Sorry I will come on it tomorrow. |
|
stalling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #tscircuit/tscircuit#1149
/claim tscircuit/tscircuit#1149