Fix: Correct package_name_with_version construction

[Excellencedev]

/claim #1717
/closes #1717

PR Description:

This PR fixes a bug where the package_name_with_version was being constructed incorrectly in useUpdatePackageFilesMutation.ts and edit-package-details-dialog.tsx. This caused issues with saving packages and managing package files. This PR corrects the construction of package_name_with_version in both files, ensuring that the API receives the correctly formatted package name and version.

[Excellencedev]

@seveibar Please review this

[Excellencedev]

@seveibar @imrishabh18 Please review this PR

[imrishabh18]

I am not sure if it's the right fix. Last time I was looking at the issue, it looked something related to react-query cache

[Excellencedev]

@imrishabh18 You are correct. The issue was that react-query was holding onto stale data. Here's the sequence
of events that caused the bug:
You change the package name in the dialog.

My newest commit targets this caching problem:

  I replaced window.history.replaceState with setLocation. This function, from the
  wouter library, triggers a proper client-side navigation. This forces the page components to re-render
  and re-run their data-fetching hooks (useCurrentPackageRelease, etc.) with the new, correct package name
  from the URL.

[seveibar]

is there any proof this fixes the issue?

[Excellencedev]

is there any proof this fixes the issue?

@seveibar I will create a test to prove it now

[Excellencedev]

is there any proof this fixes the issue?

@seveibar I have added a test for it now

[seveibar]

don't tag me for this one

[Excellencedev]

don't tag me for this one

@imrishabh18 @ArnavK-09 Please review this

[Excellencedev]

@imrishabh18 Please try to review again/ Thank you

[imrishabh18]

We don't run the playwright test in the ci anymore. Do you have a video which shows this has fixed it?

[Excellencedev]

We don't run the playwright test in the ci anymore. Do you have a video which shows this has fixed it?

Will add it

[Excellencedev]

@imrishabh18 {"error":{"error_code":"invalid_next_url","message":"The next url is not approved "https://tscircuit-abhog3qy0-tscircuit.vercel.app/authorize?redirect=https%3A%2F%2Ftscircuit-abhog3qy0-tscircuit.vercel.app%2Feditor%3Fpackage_id%3Dd2c1c529-97b0-41de-96fa-2cc0c84ba342\"","next":"https://tscircuit-abhog3qy0-tscircuit.vercel.app/authorize?redirect=https%3A%2F%2Ftscircuit-abhog3qy0-tscircuit.vercel.app%2Feditor%3Fpackage_id%3Dd2c1c529-97b0-41de-96fa-2cc0c84ba342"}}

@imrishabh18 I cannot get demo video like this

[github-actions]

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

[Excellencedev]

it is not stale