Skip to content

Pass complete serialized errors between background and proxy store #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Pass complete serialized errors between background and proxy store #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0511658
pass full errors back to proxy store
jlalmes Oct 27, 2020
203b134
reject complete errors
jlalmes Oct 27, 2020
8aa4fbf
2.1.8
jlalmes Oct 27, 2020
e820f8d
include Error prototype key values in rejected error
jlalmes Oct 27, 2020
19862bf
2.1.9
jlalmes Oct 27, 2020
9d854b0
flip assignIn arguments
jlalmes Oct 27, 2020
cdadb5d
2.1.10
jlalmes Oct 27, 2020
fd8f727
rollback flipped params
jlalmes Oct 27, 2020
e2ab412
debug logging
jlalmes Oct 27, 2020
92f0e0c
2.1.11
jlalmes Oct 27, 2020
ada368f
removed logging
jlalmes Oct 27, 2020
fde76d2
linting fixes & added serialize-error package
jlalmes Oct 27, 2020
c51401e
2.1.12
jlalmes Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "webext-redux",
"version": "2.1.7",
"name": "webext-redux-w-errors",
"version": "2.1.12",
"description": "A set of utilities for building Redux applications in Web Extensions.",
"main": "lib/index.js",
"typings": "./index.d.ts",
Expand All @@ -26,7 +26,8 @@
"homepage": "https://github.com/tshaddix/webext-redux#readme",
"dependencies": {
"lodash.assignin": "^4.2.0",
"lodash.clonedeep": "^4.5.0"
"lodash.clonedeep": "^4.5.0",
"serialize-error": "^7.0.1"
},
"devDependencies": {
"@babel/cli": "^7.2.3",
Expand Down
8 changes: 2 additions & 6 deletions src/store/Store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ import { withSerializer, withDeserializer, noop } from "../serialization";
import shallowDiff from '../strategies/shallowDiff/patch';
import {getBrowserAPI} from '../util';

const backgroundErrPrefix = '\nLooks like there is an error in the background page. ' +
'You might want to inspect your background page for more details.\n';


const defaultOpts = {
portName: DEFAULT_PORT_NAME,
state: {},
Expand Down Expand Up @@ -160,9 +156,9 @@ class Store {
const {error, value} = resp;

if (error) {
const bgErr = new Error(`${backgroundErrPrefix}${error}`);
const err = assignIn(new Error(error.message), error);

reject(assignIn(bgErr, error));
reject(err);
} else {
resolve(value && value.payload);
}
Expand Down
5 changes: 3 additions & 2 deletions src/wrap-store/wrapStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
import { withSerializer, withDeserializer, noop } from "../serialization";
import {getBrowserAPI} from '../util';
import shallowDiff from '../strategies/shallowDiff/diff';
import { serializeError } from 'serialize-error';

/**
* Responder for promisified results
Expand All @@ -26,7 +27,7 @@ const promiseResponder = (dispatchResult, send) => {
.catch((err) => {
console.error('error dispatching result:', err);
send({
error: err.message,
error: serializeError(err),
value: null
});
});
Expand Down Expand Up @@ -81,7 +82,7 @@ export default (store, {
try {
dispatchResult = store.dispatch(action);
} catch (e) {
dispatchResult = Promise.reject(e.message);
dispatchResult = Promise.reject(e);
console.error(e);
}

Expand Down