Skip to content

Invert NOB_STRIP_PREFIX and NOB_STRIP_PREFIX_GUARD_ checks #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Invert NOB_STRIP_PREFIX and NOB_STRIP_PREFIX_GUARD_ checks #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions nob.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2189,15 +2189,16 @@ NOBDEF int closedir(DIR *dirp)

#endif // NOB_IMPLEMENTATION

#ifndef NOB_STRIP_PREFIX_GUARD_
#define NOB_STRIP_PREFIX_GUARD_
#ifdef NOB_STRIP_PREFIX
// NOTE: The name stripping should be part of the header so it's not accidentally included
// several times. At the same time, it should be at the end of the file so to not create any
// potential conflicts in the NOB_IMPLEMENTATION. The header obviously cannot be at the end
// of the file because NOB_IMPLEMENTATION needs the forward declarations from there. So the
// solution is to split the header into two parts where the name stripping part is at the
// end of the file after the NOB_IMPLEMENTATION.
#ifdef NOB_STRIP_PREFIX
#ifndef NOB_STRIP_PREFIX_GUARD_
#define NOB_STRIP_PREFIX_GUARD_

#define TODO NOB_TODO
#define UNREACHABLE NOB_UNREACHABLE
#define UNUSED NOB_UNUSED
Expand Down Expand Up @@ -2304,8 +2305,8 @@ NOBDEF int closedir(DIR *dirp)
#define nprocs nob_nprocs
#define nanos_since_unspecified_epoch nob_nanos_since_unspecified_epoch
#define NANOS_PER_SEC NOB_NANOS_PER_SEC
#endif // NOB_STRIP_PREFIX
#endif // NOB_STRIP_PREFIX_GUARD_
#endif // NOB_STRIP_PREFIX_GUARD_
#endif // NOB_STRIP_PREFIX

/*
Revision history:
Expand Down
Loading