-
Notifications
You must be signed in to change notification settings - Fork 146
introduce nob_da_declare macro for simplifing dynamic array declaration #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abdorayden
wants to merge
1
commit into
tsoding:main
Choose a base branch
from
abdorayden:nob_da_declare
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #define NOB_IMPLEMENTATION | ||
| #define NOB_STRIP_PREFIX | ||
| #define NOB_DA_INIT_CAP 4 | ||
| #include "nob.h" | ||
|
|
||
| int main(void){ | ||
| da_declare(int) xs; | ||
| da_append(&xs , 10); | ||
|
|
||
| nob_log(INFO , "Hello World %d " , xs.items[0]); | ||
| return 0; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have used practically the same macro for some time and find it neat.
As you describe here it can be used as sort of "anonymous" type. However this usage might make some compilers warn about argument types. But it works i guess.
You can typedef which solves the warnings.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for sharing your experience with nob_da_declare and the suggestion about using typedef to avoid warnings.
You're absolutely right-this macro effectively creates an anonymous structure, and using typedef helps maintain cleaner code and prevents compiler warnings.
And you have ability to declare and use these structures globally (outside main) is a great point -it adds flexibility in how the macro can be applied