Skip to content

Readability #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Readability #37

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3e0073e
return after build wasm
brccabral Mar 5, 2025
5ad15f7
return after show help
brccabral Mar 5, 2025
550e4b8
return after run tests
brccabral Mar 5, 2025
92268d8
return after demos
brccabral Mar 5, 2025
10fc874
return after tools
brccabral Mar 5, 2025
05f3368
return after assets
brccabral Mar 5, 2025
12d440f
build all first
brccabral Mar 5, 2025
548c87f
removed else if, early return
brccabral Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
157 changes: 83 additions & 74 deletions nob.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,86 +145,95 @@ int main(int argc, char **argv)

const char *program = shift_args(&argc, &argv);

if (argc > 0) {
const char *subcmd = shift_args(&argc, &argv);
if (strcmp(subcmd, "tools") == 0) {
if (!build_tools(&cmd)) return 1;
} else if (strcmp(subcmd, "assets") == 0) {
if (!build_assets(&cmd)) return 1;
} else if (strcmp(subcmd, "tests") == 0 || strcmp(subcmd, "test") == 0) {
if (!build_tests(&cmd)) return 1;
if (argc > 0) {
cmd_append(&cmd, "./build/test");
da_append_many(&cmd, argv, argc);
if (!cmd_run_sync_and_reset(&cmd)) return 1;
}
} else if (strcmp(subcmd, "demos") == 0) {
if (argc <= 0) {
if (!build_all_vc_demos(&cmd, &procs)) return 1;
return 0;
}
if (argc <= 0) {
if (!build_tools(&cmd)) return 1;
if (!build_assets(&cmd)) return 1;
if (!build_tests(&cmd)) return 1;
if (!build_all_vc_demos(&cmd, &procs)) return 1;
return 0;
}

const char *name = shift(argv, argc);
if (argc <= 0) {
build_vc_demo(&cmd, &procs, name);
if (!procs_wait_and_reset(&procs)) return 1;
const char *src_path = temp_sprintf("./build/demos/%s.wasm", name);
const char *dst_path = temp_sprintf("./wasm/%s.wasm", name);
if (!copy_file(src_path, dst_path)) return 1;
return 0;
}
const char *subcmd = shift_args(&argc, &argv);
if (strcmp(subcmd, "tools") == 0) {
if (!build_tools(&cmd)) return 1;
return 0;
}
if (strcmp(subcmd, "assets") == 0) {
if (!build_assets(&cmd)) return 1;
return 0;
}
if (strcmp(subcmd, "tests") == 0 || strcmp(subcmd, "test") == 0) {
if (!build_tests(&cmd)) return 1;
if (argc > 0) {
cmd_append(&cmd, "./build/test");
da_append_many(&cmd, argv, argc);
if (!cmd_run_sync_and_reset(&cmd)) return 1;
}
return 0;
}
if (strcmp(subcmd, "demos") == 0) {
if (argc <= 0) {
if (!build_all_vc_demos(&cmd, &procs)) return 1;
return 0;
}

const char *name = shift(argv, argc);
if (argc <= 0) {
build_vc_demo(&cmd, &procs, name);
if (!procs_wait_and_reset(&procs)) return 1;
const char *src_path = temp_sprintf("./build/demos/%s.wasm", name);
const char *dst_path = temp_sprintf("./wasm/%s.wasm", name);
if (!copy_file(src_path, dst_path)) return 1;
return 0;
}

const char *platform = shift(argv, argc);
if (strcmp(platform, "sdl") == 0) {
build_sdl_demo(&cmd, &procs, name);
if (!procs_wait_and_reset(&procs)) return 1;
if (argc <= 0) return 0;
const char *run = shift(argv, argc);
if (strcmp(run, "run") != 0) {
usage(program);
nob_log(ERROR, "unknown action `%s` for SDL demo: %s", run, name);
return 1;
}
cmd_append(&cmd, temp_sprintf("./build/demos/%s.sdl", name));
if (!cmd_run_sync_and_reset(&cmd)) return 1;
return 0;
} else if (strcmp(platform, "term") == 0) {
build_term_demo(&cmd, &procs, name);
if (!procs_wait_and_reset(&procs)) return 1;
if (argc <= 0) return 0;
const char *run = shift(argv, argc);
if (strcmp(run, "run") != 0) {
usage(program);
nob_log(ERROR, "unknown action `%s` for Terminal demo: %s", run, name);
return 1;
}
cmd_append(&cmd, temp_sprintf("./build/demos/%s.term", name));
if (!cmd_run_sync_and_reset(&cmd)) return 1;
return 0;
} else if (strcmp(platform, "wasm") == 0) {
build_wasm_demo(&cmd, &procs, name);
if (!procs_wait_and_reset(&procs)) return 1;
const char *src_path = temp_sprintf("./build/demos/%s.wasm", name);
const char *dst_path = temp_sprintf("./wasm/%s.wasm", name);
if (!copy_file(src_path, dst_path)) return 1;
} else {
const char *platform = shift(argv, argc);
if (strcmp(platform, "sdl") == 0) {
build_sdl_demo(&cmd, &procs, name);
if (!procs_wait_and_reset(&procs)) return 1;
if (argc <= 0) return 0;
const char *run = shift(argv, argc);
if (strcmp(run, "run") != 0) {
usage(program);
nob_log(ERROR, "unknown demo platform %s", platform);
nob_log(ERROR, "unknown action `%s` for SDL demo: %s", run, name);
return 1;
}
} else if(strcmp(subcmd, "help") == 0) {
usage(program);
} else {
usage(program);
nob_log(ERROR, "Unknown command `%s`", subcmd);
return 1;
cmd_append(&cmd, temp_sprintf("./build/demos/%s.sdl", name));
if (!cmd_run_sync_and_reset(&cmd)) return 1;
return 0;
}
} else {
if (!build_tools(&cmd)) return 1;
if (!build_assets(&cmd)) return 1;
if (!build_tests(&cmd)) return 1;
if (!build_all_vc_demos(&cmd, &procs)) return 1;
if (strcmp(platform, "term") == 0) {
build_term_demo(&cmd, &procs, name);
if (!procs_wait_and_reset(&procs)) return 1;
if (argc <= 0) return 0;
const char *run = shift(argv, argc);
if (strcmp(run, "run") != 0) {
usage(program);
nob_log(ERROR, "unknown action `%s` for Terminal demo: %s", run, name);
return 1;
}
cmd_append(&cmd, temp_sprintf("./build/demos/%s.term", name));
if (!cmd_run_sync_and_reset(&cmd)) return 1;
return 0;
}
if (strcmp(platform, "wasm") == 0) {
build_wasm_demo(&cmd, &procs, name);
if (!procs_wait_and_reset(&procs)) return 1;
const char *src_path = temp_sprintf("./build/demos/%s.wasm", name);
const char *dst_path = temp_sprintf("./wasm/%s.wasm", name);
if (!copy_file(src_path, dst_path)) return 1;
return 0;
}
usage(program);
nob_log(ERROR, "unknown demo platform %s", platform);
return 1;
}
if (strcmp(subcmd, "help") == 0) {
usage(program);
return 0;
}

return 0;
usage(program);
nob_log(ERROR, "Unknown command `%s`", subcmd);
return 1;
}