Skip to content

fix(progress): the style is abnormal when percent is greater than 100 #7146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 8, 2025
Merged

fix(progress): the style is abnormal when percent is greater than 100 #7146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d650bd8
fix: the style is abnormal when percent is greater than 100
devhaozi Aug 15, 2025
d005bdf
fix: add changelog
devhaozi Aug 15, 2025
81e4b4b
fix: add changelog
devhaozi Aug 15, 2025
bf0b33d
Merge branch 'main' into main
devhaozi Sep 6, 2025
dca6aa6
Merge branch 'main' into main
devhaozi Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.en-US.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
- Fix the issue of style confusion in `n-carousel` when there is only one image, close [#6476](https://github.com/tusen-ai/naive-ui/issues/6476)
- Fix `n-marquee` component 'Non-function value encountered for default slot' warning.
- Fix memory leak caused by `n-upload` icon.
- Fix `n-progress` style is incorrect after using the dashboard mode exceeding 100%, closes [#6627](https://github.com/tusen-ai/naive-ui/issues/6627)

### Features

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
- 修复 `n-progress` 多个 `type="circle"`情况下样式覆盖问题，关闭 [#7172](https://github.com/tusen-ai/naive-ui/issues/7172)
- 修复 `n-marquee` 组件 'Non-function value encountered for default slot' 警告
- 修复 `n-upload` icon 导致的内存泄露问题
- 修复 `n-progress` 使用仪表盘模式超过 100% 之后样式不正确，关闭 [#6627](https://github.com/tusen-ai/naive-ui/issues/6627)

### Features

Expand Down
2 changes: 1 addition & 1 deletion src/progress/src/Circle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export default defineComponent({
: typeof props.fillColor === 'object'
? `url(#${gradientIdRef.value})`
: (strokeColor as string),
strokeDasharray: `${(percent / 100) * (len - gapDegree)}px ${
strokeDasharray: `${(Math.min(percent, 100) / 100) * (len - gapDegree)}px ${
viewBoxWidth * 8
}px`,
strokeDashoffset: `-${gapDegree / 2}px`,
Expand Down