Various CDDL fixes: found based on the QuickCheck testing of the ledger-state #159
+381
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies various fixes to CDDL (Concise Data Definition Language) specifications based on issues discovered through QuickCheck testing of the ledger state.
Key changes:
- Updated pool metadata hash type from fixed-size
hash32to flexibleVBytes - Enhanced governance action definitions to allow optional governance action IDs and added constitution field
- Introduced new
gov_params_updaterule for governance parameter updates with all fields optional - Relaxed major protocol version constraint from bounded range (1-9) to unbounded
VUInt
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
Cardano/SCLS/Namespace/Snapshots.hs |
Changed pool_metadata_hash from hash32 to VBytes to allow variable-length hashes |
Cardano/SCLS/Namespace/GovProposals.hs |
Added constitution import, made governance action IDs optional, created gov_params_update rule with all optional fields, and added constitution field to "New constitution" action |
Cardano/SCLS/Common.hs |
Removed bounded protocol version range constraint, allowing any VUInt value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There is no restriction on hash size in ledger state protocol CDDLs. It means that we should not restrict hash as well.
We allow all versions in protocol_version so we will not need to update spec on each release.
If was a bug that requied exactly one commitie member to be removed during update. Quite an interesting policy and I'm curious how that could work. But anyway it's a bug and it's fixed now.
Each field in the protocol parameters update may be missing. Current spec allows that.
Contributor
Author
|
I've updates specs by adding fixes from comments to CIP. |
nc6
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All CDDL updated so the quickcheck tests in the cardano-ledger passes and we can store and validate all the entries,