-
-
Notifications
You must be signed in to change notification settings - Fork 499
Run different version of mypy in ci #2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run different version of mypy in ci #2671
Conversation
843be52
to
5ade464
Compare
a5c9dec
to
f328c33
Compare
@sobolevn This is ready for review, was much easier now that we have uv. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not quite sure about that :(
It brings several new quirks for maintenance, not sure if it really helps though...
Yeah I'm also not completely sure, but it would have caught #2665 earlier and would have probably also help with #2724 (comment) were a mypy version bump introduced a regression in our plugin. I feel like the kind of bugs related to mypy versions are the complicated ones, often related to the plugin. Maybe others core maintainer of django-stubs have an opinion on the subject ? |
I fear this is about to become even more non-viable. In mypy 1.17 or 1.18 various options related to the formatting of types in errors are going to be obsolete. This means that we'll need to fix our tests - I have a branch ready with some of those changes which I'll open a PR for when the next release comes along... But, yeah, testing across versions will be nigh on impossible. |
That's sad but yeah, I suppose it would add too much of a burden |
I have made things!
Run ci with supported mypy version ie
1.13
,1.14
,1.15
,1.16
andmaster
branch on github.