Django 6.0: Add databases= parameter to check_generic_foreign_keys, check_model_name_lengths
#2951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
changed the title
databases= parameter to check_generic_foreign_keys, check_model_name_lengths
intgr
approved these changes
Dec 15, 2025
Collaborator
intgr
left a comment
intgr
left a comment
There was a problem hiding this comment.
Great, thanks!
By the way, you opened the PR from user @Tosinibikunle but your commits show up from @AjibadeHassan instead. Is this OK, or did you configure git email address incorrectly by accident?
sobolevn
approved these changes
Dec 15, 2025
…hs in contrib/contenttypes
…kunle/django-stubs into adding-django-stubs-6.0
Contributor
Author
It was a mistake from my end |
Contributor
Author
|
Should I create a new branch or continue working on this one? |
Collaborator
|
Separate branch and PR every time please. But feel free to add more changes in one go than this. Or not, it's up to you. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added stubs for check_generic_foreign_keys and check_model_name_lengths functions in contrib/contenttypes/checks.pyi
#2944