Replace via.placeholder.com images with picsum.photos images #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2025
|
Been a while since this was put up and mentioned. I cam across this issue because a few doc site use these apis for example https://tanstack.com/router/v1/docs/framework/react/examples/location-masking which is now broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via.placeholder.com was purchased by a warehouse company and as a result all image URLs in data.json are invalid. This PR replaced the image URLs in data.json with valid image URLs from picsum.photos.
Additional Details:
Image IDs on picsum.photos are not sequential and therefore the image IDs used are not sequential. A script was wrote to parse the v2/list endpoint provided by picsum so that only valid IDs were used in this PR.There are only about 995 unique image IDs on picsum; so there are only 995 unique image URLs in this PR change. Since there are 5000 images in the data.json I decided to loop though the 995 unique IDs while replacing the image URLs. As a result some picsum images are repeated. For example, the first image with id 0 shows up 6 times.I opened an issue on the picsum source repo asking for permission to use their service in this project.
Permission was granted along with a suggestion for using the seed generated images instead of hard coding image IDs. PR updated to use the recommended seed generation instead of hard coded IDs.