allow ChartJS custom default font #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Siriwat. I've had problems with using Chartjs globals in the past because the settings would leak and affect other chart renders. I think that may be a problem in this case. We should add a test in |
|
Excuse me, I don't quite get what the problem is. What will it leak and how would it effect the rendering (except for the font). By the way, I will look into the test after my work hours ;) |
|
Sorry, I misunderstood. I was imagining and option that allows you to set font color. That could cause problems because the Chart object persists between requests. However, you've implemented this as an envar, which affects ALL charts anyway, so we don't have to worry about that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added support for custom font via ENV.