-
Notifications
You must be signed in to change notification settings - Fork 53
Add versioning to specs #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All specs are MAJOR.MINOR. MAJOR is incremented on breaking changes, MINOR on incompatible changes. A 0.x is experimental. filename/MAJOR.MINOR for git tag for each new version of a given spec.
All at 1.0 apart from LFHS and VOA which are 0.1 as WIP
keszybz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one question.
|
|
||
| ## License | ||
|
|
||
| All specifications are licensed under [CC-BY-4.0](https://spdx.org/licenses/CC-BY-4.0.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the individual spec files have a SPDX header with CC-BY-4.0, so this just adds a note that is more visible to readers.
| All specifications are versioned. | ||
|
|
||
| The versioning format is MAJOR.MINOR. | ||
| Compatible changes increment the MINOR version. | ||
| Incompatible changes increment the MAJOR version and reset the MINOR version to `0`. | ||
|
|
||
| Work in progress specifications have a MAJOR version of `0`. | ||
|
|
||
| A `filename/MAJOR.MINOR` git tag will be created when a new version of a given spec is released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this is great. I had something like this in mind, but the wording is particularly concise and clear.
|
|
||
| | Version | Changes | | ||
| |---------|---------| | ||
| | 0.1 | Work in progress | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think we could put 1.0 here. Do you anticipate any bigger changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It had an important change only two days ago, so wanted to be a bit careful here and get the general structure right. We can easily do 1.0 in a separate PR if we feel it's ready
No description provided.