Skip to content
This repository was archived by the owner on Dec 3, 2019. It is now read-only.

Fixed overflow in ELF::NededLibs and ELF::WalkTable #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed overflow in ELF::NededLibs and ELF::WalkTable #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/symbol.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ std::vector<std::string> ELF::NeededLibs() {
std::vector<std::string> needed;
const shdr_t *s = shdr(dynamic_);
const shdr_t *d = shdr(dynstr_);
for (uint16_t i = 0; i < s->sh_size / s->sh_entsize; i++) {
for (word_t i = 0; i < s->sh_size / s->sh_entsize; i++) {
const dyn_t *dyn =
reinterpret_cast<const dyn_t *>(p() + s->sh_offset + i * s->sh_entsize);
if (dyn->d_tag == DT_NEEDED) {
Expand All @@ -127,7 +127,7 @@ PyABI ELF::WalkTable(int sym, int str, PyAddresses *addrs) {
bool have_abi = false;
const shdr_t *s = shdr(sym);
const shdr_t *d = shdr(str);
for (uint16_t i = 0; i < s->sh_size / s->sh_entsize; i++) {
for (word_t i = 0; i < s->sh_size / s->sh_entsize; i++) {
if (have_abi && addrs->tstate_addr && addrs->interp_head_addr &&
addrs->interp_head_fn_addr) {
break;
Expand Down
2 changes: 2 additions & 0 deletions src/symbol.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#define dyn_t Elf64_Dyn
#define sym_t Elf64_Sym
#define addr_t Elf64_Addr
#define word_t Elf64_Word
#define ARCH_ELFCLASS ELFCLASS64
#else
#define ehdr_t Elf32_Ehdr
Expand All @@ -41,6 +42,7 @@
#define dyn_t Elf32_Dyn
#define sym_t Elf32_Sym
#define addr_t Elf32_Addr
#define word_t Elf32_Word
#define ARCH_ELFCLASS ELFCLASS32
#endif

Expand Down