Skip to content

Conversation

cpaelzer
Copy link
Collaborator

@cpaelzer cpaelzer commented Oct 1, 2025

We had improved the related text in the general explanation in ed8ce6c,
but without being in the review section it might be forgotten too easily.

Discussing that in the MIR team meeting made it clear that we want an improvement of the related section.

To improve on this, we do:

  • Extend the review section with related explanations in the RULE block
  • Move the non useful tool check from TODO (kept) to rules (read but not kept in final comment)
  • Refer to the now established section on rev-deps in the ubuntu project docs
  • Make checking for runtime-deps and "stuff that kind of got into the binary" explicit separate aspects we check for.

We had improved the text for humans in ed8ce6c, but without
being in the review section it might be forgotten too easily.
To improve on this, we do:
- Extend the review section with related explanations
- Move the non useful tool check from TODO (kept) to rules (read but not
  in final comment)
- Refer to the now established section on rev-deps in the docs
- Make checking for runtime and "stuff that kind of got into the binary"
  explicit separate statements we check for.

Signed-off-by: Christian Ehrhardt <[email protected]>
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change to move the tools themselves inside the RULES. I think the overall makes it clearer both in what to take into account and the why (especially the part about build-time dependencies ending up in the final binary).
Thanks for the change.

@cpaelzer cpaelzer added the MIR For the attention of the MIR team label Oct 7, 2025
Copy link
Collaborator

@joalif joalif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@cpaelzer cpaelzer merged commit 613e753 into ubuntu:main Oct 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MIR For the attention of the MIR team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants