DMB: reduce the complexity of the voting description #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpaelzer
force-pushed
the
dmb-vote-simplify-for-first-time-readers
branch
from
164d018 to
ca43865
Compare
cpaelzer
requested review from
athos-ribeiro,
bdrung and
utkarsh2102
as code owners
bdrung
reviewed
Oct 2, 2025
The text used to be in two places, due to former times struggling with attendees it is very complex. This is not changing the rules, but making it quite readable, unifying the two we moved together and moving the daunting code example out of the first read experience. Signed-off-by: Christian Ehrhardt <[email protected]>
We yet again have two places trying to explain. Clarify what the chair does in the chair section and only refer to the one place we go into detail on qorum and voting. Signed-off-by: Christian Ehrhardt <[email protected]>
Signed-off-by: Christian Ehrhardt <[email protected]>
The text had several cases which were not in the code like the follow up or the consequence of a lack of qorum. While not convinced that we would still need/want the code, if we do make it match the text more closely. Signed-off-by: Christian Ehrhardt <[email protected]>
Co-authored-by: Benjamin Drung <[email protected]>
Suggested-by: Benjamin Drung <[email protected]> Signed-off-by: Christian Ehrhardt <[email protected]>
Fixed "NameError: name 'non_abstain' is not defined" Suggested-by: Benjamin Drung <[email protected]> Signed-off-by: Christian Ehrhardt <[email protected]>
total_members is not really an argument, it is how the DMB is defined. Make it not a function argument to represent that. Signed-off-by: Christian Ehrhardt <[email protected]>
Avoid nested if's makes it even more readable. Suggested-by: Benjamin Drung <[email protected]> Signed-off-by: Christian Ehrhardt <[email protected]>
Tracking and comparing to missing_votes makes it even more readable. It further allows to differentiate non-unanimous cases into final or needing follow up votes to come in. Suggested-by: Benjamin Drung <[email protected]> Signed-off-by: Christian Ehrhardt <[email protected]>
qouorum -> quorum Signed-off-by: Christian Ehrhardt <[email protected]>
cpaelzer
force-pushed
the
dmb-vote-simplify-for-first-time-readers
branch
from
16909d6 to
2b9b4d1
Compare
|
Updates:
|
utkarsh2102
approved these changes
Oct 8, 2025
I know, to be clear - Sally and I are quite convinced that the text alone is better for humans. Now the code variant ... is it needed - well maybe.
That, a step forward without the claim of perfection is exactly what I had in mind
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the review we found this in two places and to be quite daunting.
I understand it is due to former times struggling with attendees and it is very complex.
This is not changing the rules, but making it quite readable I hope.
By unifying the two sections we moved together, rewording to be one flow to read and moving the daunting code example out of the first read experience.