Add support for adding request contextual data to configuration objects. #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albu-diku
force-pushed
the
addition/configuration-context
branch
from
63aa38c to
e984f18
Compare
albu-diku
force-pushed
the
addition/configuration-context
branch
from
e984f18 to
b2b89e3
Compare
albu-diku
force-pushed
the
addition/configuration-context
branch
from
b2b89e3 to
fcf4097
Compare
This change adds a small namespace to configuraton objects that behaves like a dictonary allowing objects to made available to e.g. request handlers. Opt to do this by specialising Configuration rather than changing it directly. The rationale is to preserve a distinction between static parts of the configuration of a dpeloyment, which do no change at runtime, versus e.g. a users locale which would be different for each request though consistent for its duration. Such functionality it needed to support templates without restorting to globals within the current system architecture; only congifuration objects are already threaded through most of the places this would need to be available with the correct semantics of an instance being created wherever it is needed.
albu-diku
force-pushed
the
addition/configuration-context
branch
from
2db321f to
3c31144
Compare
|
Affected by pre-existing lint issue: #335 Does not suffer any other issues of which I am aware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a small namespace to configuraton objects that behaves like a dictonary allowing objects to made available to e.g. request handlers.
Such functionality it needed to support templates without restorting to globals within the current system architecture; only congifuration objects are already threaded through most of the places this would need to be available with the correct semantics of an instance being created wherever it is needed.
Depends on: #328