Improved unit test coverage of mig lib daemon #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbardino
added this to the
Migration of scripts and services to new FHSesque locations milestone
jonasbardino
added
the
test-only
albu-diku
reviewed
Oct 21, 2025
albu-diku
reviewed
Oct 21, 2025
albu-diku
reviewed
Oct 21, 2025
…on etc. Add coverage of several previously missing branches and corner cases. - Direct event helper testing - Signal handler verification - Concurrent event handling - Nap timing accuracy checks - Multiple reset cycles - Error cases like invalid arguments - Various sleep interruption scenarios
…t in unit tests to increase isolation and be able to test handling when no handlers where registered. Added unit test coverage: - Immediate sleep exit with max_secs < nap_secs - Positional argument handling - Negative max_secs handling - Zero max_secs handling - Unregistered signal safety - Consecutive signal handling Perhaps a stand-alone test for the new unregister_signal_handlers should also be added.
- Verify explicit unregistration of signal handlers - Test sleep terminating after a condition becomes true - Edge case test for equal max/sleep durations - Test error handling when break conditions raise exceptions - Direct tests of state reset and setting helpers - Integration test with real signal delivery
…guration`. Move used_signal accounting to class-level. Perhaps we want to maintain it on actual use and add helpers to track active ones eventually.
jonasbardino
force-pushed
the
add/improved-unit-test-coverage-of-mig-lib-daemon
branch
from
d526fdd to
7b8d825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved unit test coverage of
mig/lib/daemon.pyto aim for complete coverage. Added a lot of corner case tests to test signal passing and handlers. Some of the tests include fuzzy timing assertions, which may need further tweaking to avoid false positives.Adds one new function to the tested library to remove already registered signal handlers, but it is only ever used in the unit tests so far.
Slightly tweaks
interruptible_sleepcorner cases to fail an assertion if called with non-positivenap_secsand to return right away if called withmax_sleepless thannap_secs. Both are unused corner cases only used in the test for now but they may or may not be of use to daemons in the future.