-
Notifications
You must be signed in to change notification settings - Fork 0
Make sigrap (HRDetect, MutationalPatterns) individual process #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2025
scwatts
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over the changes and all LGTM!
qclayssen
added a commit
that referenced
this pull request
Oct 2, 2025
qclayssen
added a commit
that referenced
this pull request
Oct 7, 2025
* add process and config for vcf2maf * fix path vep data * remove duplicate * fix and linting * remove params from VCF2MAF process * fix and simplify process * add meta.key to channel * add genome build as input * add dockerfile * Make sigrap (HRDetect, MutationalPatterns) individual process (#16) * remove trace of genome build and hardcode in VCF2MAF * use biocontainers container for vcf2maf * remove string interpolation * change to stub no version template * revert deleted line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HRDetect, CHORD, MutationalPatterns were run in cancer report (gpgr) generation process.
Making individual process avoid having computation when gerating cancer report
link with (sigrap #13)[https://github.com/umccr/sigrap/pull/13]
and cancer report (gpgr #91)[https://github.com/umccr/gpgr/pull/91]